[Payments] Changes to validation in the Credit Card editor

[Payments] Changes to validation in the Credit Card editor

Several changes are bundled here:
* Card icons will now dim dynamically as the network is selected.
* ValidatingTextfield::IsValid no longer has side effects
* Error labels are refreshed differently
* ValidationDelegate now gets passed |was_blurred| for textfield, to
  allow performing some tasks before the blur (selecting card icons).
* Reverse the validity logic on the expiration custom view (oops).

BUG=721619
TEST=existing

Review-Url: https://codereview.chromium.org/2896263002
Cr-Commit-Position: refs/heads/master@{#474060}
Committed: https://chromium.googlesource.com/chromium/src/+/dbe9253353485376a03c2c35bdd462922ecb80af

[Mathieu, 2017-05-23 15:05:48]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[Mathieu, 2017-05-23 15:06:07]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-05-23 15:06:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2017-05-23 15:06:56]

mathp@chromium.org changed reviewers:
+ anthonyvd@chromium.org

[Mathieu, 2017-05-23 15:06:57]

Anthony PTAL

[Mathieu, 2017-05-23 15:07:14]

Description was changed from

==========
[Payments] Changes to validation in the Credit Card editor

Several changes are bundled here:
* Card icons will now dim dynamically as the network is selected.
* ValidatingTextfield::IsValid no longer has side effects
* Error labels are refreshed differently
* ValidationDelegate now gets passed |was_blurred| for textfield, to
  allow performing some tasks before the blur (selecting card icons).
* Reverse the validity logic on the expiration custom view (oops).

BUG=721619
TEST=existing
==========

to

==========
[Payments] Changes to validation in the Credit Card editor

Several changes are bundled here:
* Card icons will now dim dynamically as the network is selected.
* ValidatingTextfield::IsValid no longer has side effects
* Error labels are refreshed differently
* ValidationDelegate now gets passed |was_blurred| for textfield, to
  allow performing some tasks before the blur (selecting card icons).
* Reverse the validity logic on the expiration custom view (oops).

BUG=721619
TEST=existing
==========

[commit-bot: I haz the power, 2017-05-23 15:50:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 15:50:41]

Dry run: This issue passed the CQ dry run.

[anthonyvd, 2017-05-23 15:59:43]

lgtm

https://codereview.chromium.org/2896263002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
(right):

https://codereview.chromium.org/2896263002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc:59: const
float kDimmedCardIconOpacity = 0.33f;
Didn't Bruno specify 50%?

[Mathieu, 2017-05-23 17:45:44]

On 2017/05/23 15:59:43, anthonyvd wrote:
> lgtm
> 
>
https://codereview.chromium.org/2896263002/diff/20001/chrome/browser/ui/views...
> File chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
> (right):
> 
>
https://codereview.chromium.org/2896263002/diff/20001/chrome/browser/ui/views...
> chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc:59:
const
> float kDimmedCardIconOpacity = 0.33f;
> Didn't Bruno specify 50%?

33% it is!

[Mathieu, 2017-05-23 17:46:07]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-05-23 17:46:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
anthonyvd@chromium.org
Link to the patchset: https://codereview.chromium.org/2896263002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-23 17:47:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 18:19:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 18:19:36]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mathieu, 2017-05-23 18:23:44]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2017-05-23 18:24:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 19:38:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 19:38:33]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Mathieu, 2017-05-23 19:54:28]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2017-05-23 19:55:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 21:27:59]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495569268071370,
"parent_rev": "6f7158a4e3131b3b47c007f5aa8970ccbce01ca3", "commit_rev":
"c71bfff0acabf3bd51ebd87a320464ed51c46178"}

[commit-bot: I haz the power, 2017-05-23 21:28:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495569268071370,
"parent_rev": "f1e5140acfbff8d0745bae0ceb0a95a1bf7ad566", "commit_rev":
"dbe9253353485376a03c2c35bdd462922ecb80af"}

[commit-bot: I haz the power, 2017-05-23 21:28:31]

Description was changed from

==========
[Payments] Changes to validation in the Credit Card editor

Several changes are bundled here:
* Card icons will now dim dynamically as the network is selected.
* ValidatingTextfield::IsValid no longer has side effects
* Error labels are refreshed differently
* ValidationDelegate now gets passed |was_blurred| for textfield, to
  allow performing some tasks before the blur (selecting card icons).
* Reverse the validity logic on the expiration custom view (oops).

BUG=721619
TEST=existing
==========

to

==========
[Payments] Changes to validation in the Credit Card editor

Several changes are bundled here:
* Card icons will now dim dynamically as the network is selected.
* ValidatingTextfield::IsValid no longer has side effects
* Error labels are refreshed differently
* ValidationDelegate now gets passed |was_blurred| for textfield, to
  allow performing some tasks before the blur (selecting card icons).
* Reverse the validity logic on the expiration custom view (oops).

BUG=721619
TEST=existing

Review-Url: https://codereview.chromium.org/2896263002
Cr-Commit-Position: refs/heads/master@{#474060}
Committed:
https://chromium.googlesource.com/chromium/src/+/dbe9253353485376a03c2c35bdd4...
==========

[commit-bot: I haz the power, 2017-05-23 21:28:32]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dbe9253353485376a03c2c35bdd4...