chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc - Issue 2896263002: [Payments] Changes to validation in the Credit Card editor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

Issue 2896263002: [Payments] Changes to validation in the Credit Card editor (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc ('k') | chrome/browser/ui/views/payments/editor_view_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

diff --git a/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc b/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

index 2e081e933b7ea42a1c4b9b3f6e597e6dc44ac4d8..53fb746688261b2ab17fc9c32ab038d5ac510326 100644

--- a/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

+++ b/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

@@ -392,6 +392,11 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCreditCardEditorTest, EditingExpiredCard) {

EXPECT_EQ(base::ASCIIToUTF16("2017"),

GetComboboxValue(autofill::CREDIT_CARD_EXP_4_DIGIT_YEAR));

+ views::Combobox* combobox = static_cast<views::Combobox*>(

+ dialog_view()->GetViewByID(EditorViewController::GetInputFieldViewId(

+ autofill::CREDIT_CARD_EXP_MONTH)));

+ EXPECT_TRUE(combobox->HasFocus());

// Fixing the expiration date.

SetComboboxValue(base::ASCIIToUTF16("11"), autofill::CREDIT_CARD_EXP_MONTH);