chrome/browser/ui/views/payments/validating_combobox.cc - Issue 2896263002: [Payments] Changes to validation in the Credit Card editor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/validating_combobox.cc

Issue 2896263002: [Payments] Changes to validation in the Credit Card editor (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/payments/validating_combobox.cc

diff --git a/chrome/browser/ui/views/payments/validating_combobox.cc b/chrome/browser/ui/views/payments/validating_combobox.cc

index 642cae4b1b499185f405c5dca4ca739250e6f113..0a451d5a40f655580479ef5c9f52d7adb97c3543 100644

--- a/chrome/browser/ui/views/payments/validating_combobox.cc

+++ b/chrome/browser/ui/views/payments/validating_combobox.cc

@@ -47,9 +47,7 @@ void ValidatingCombobox::OnComboboxModelChanged(

}

bool ValidatingCombobox::IsValid() {

- bool valid = delegate_->IsValidCombobox(this);

- SetInvalid(!valid);

- return valid;

+ return delegate_->IsValidCombobox(this);

}

void ValidatingCombobox::Validate() {