Issue 2896183002: Rename StringCallback to FunctionStringCallback.

Issue 2896183002: Rename StringCallback to FunctionStringCallback. (Closed)

Created:
3 years, 7 months ago by Shanmuga Pandi

Modified:
3 years, 7 months ago

Reviewers:
tkent, fs, foolip

CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dcheng, dglazkov+blink, eae+blinkwatch, rwlbuis, sof

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

Rename StringCallback to FunctionStringCallback. Rename StringCallback to FunctionStringCallback in DataTransferItem interface. spec: https://html.spec.whatwg.org/#the-datatransferitem-interface BUG=701477 Review-Url: https://codereview.chromium.org/2896183002 Cr-Commit-Position: refs/heads/master@{#474955} Committed: https://chromium.googlesource.com/chromium/src/+/6757c9566c56bdf797701f7e1628bae147514109

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -101 lines)			Patch
M	third_party/WebKit/Source/core/clipboard/DataTransferItem.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/core/clipboard/DataTransferItem.idl	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/core/core_idl_files.gni	View	2 chunks	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/dom/BUILD.gn	View	2 chunks	+1 line, -1 line	0 comments	Download
A +	third_party/WebKit/Source/core/dom/FunctionStringCallback.h	View	1 chunk	+6 lines, -5 lines	0 comments	Download
A +	third_party/WebKit/Source/core/dom/FunctionStringCallback.idl	View	1 chunk	+1 line, -2 lines	0 comments	Download
D	third_party/WebKit/Source/core/dom/StringCallback.h	View	1 chunk	+0 lines, -48 lines	0 comments	Download
D	third_party/WebKit/Source/core/dom/StringCallback.idl	View	1 chunk	+0 lines, -36 lines	0 comments	Download

Total messages: 8 (4 generated)

lgtm Very minor step forward (it's still a 'callback interface' here while the spec has ...

3 years, 7 months ago (2017-05-24 08:02:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896183002/1

3 years, 7 months ago (2017-05-26 05:24:08 UTC) #5

commit-bot: I haz the power

3 years, 7 months ago (2017-05-26 07:27:59 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6757c9566c56bdf797701f7e1628...