Reorganize the maintenance of several text node related members in TextIterator

Reorganize the maintenance of several text node related members in TextIterator

Some members of TextIterator are used only by text node related functions, but
are initialized/reset at multiple places in the class. This patch reorganizes
them so that they are maintained solely by text node related functions/code.
- offset_
- handled_first_letter_
- first_letter_text_

BUG=721957
TEST=n/a; shouldn't have any behavioral change

Review-Url: https://codereview.chromium.org/2896023003
Cr-Commit-Position: refs/heads/master@{#475231}
Committed: https://chromium.googlesource.com/chromium/src/+/2d8f80cfe9a0069c01a44d3f209b69e5186da2fc

[Xiaocheng, 2017-05-23 01:05:44]

Description was changed from

==========
Reorganize the maintenance of several text node related fields in TextIterator

BUG=
==========

to

==========
Reorganize several text node related fields in TextIterator

BUG=
==========

[Xiaocheng, 2017-05-24 03:18:44]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 03:19:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-24 03:24:34]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 03:25:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-24 18:24:25]

Description was changed from

==========
Reorganize several text node related fields in TextIterator

BUG=
==========

to

==========
Reorganize the maintenance of several text node related members in TextIterator

The following three members are used only in text node handling, but are
initialized/reset at multiple places. This patch moves their init/reset to
HandleTextNode() since HandleTextNode() is called only once for each text node.
- offset_
- handled_first_letter_
- first_letter_text_

The following member is used only when deciding whether there is a whitespace
at the end of a text node that should be emitted, but hasn't been emitted during
the handling of the node. Since its use is limited at two places, it should also
be reset at those two places.
- last_text_node_ends_with_collapsed_space_

BUG=721957
TEST=n/a; shouldn't have any behavioral change
==========

[Xiaocheng, 2017-05-24 18:24:34]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-05-24 18:24:35]

PTAL.

[Xiaocheng, 2017-05-24 18:26:42]

Description was changed from

==========
Reorganize the maintenance of several text node related members in TextIterator

The following three members are used only in text node handling, but are
initialized/reset at multiple places. This patch moves their init/reset to
HandleTextNode() since HandleTextNode() is called only once for each text node.
- offset_
- handled_first_letter_
- first_letter_text_

The following member is used only when deciding whether there is a whitespace
at the end of a text node that should be emitted, but hasn't been emitted during
the handling of the node. Since its use is limited at two places, it should also
be reset at those two places.
- last_text_node_ends_with_collapsed_space_

BUG=721957
TEST=n/a; shouldn't have any behavioral change
==========

to

==========
Reorganize the maintenance of several text node related members in TextIterator

Some members of TextIterator are used only by text node related functions, but
are initialized/reset at multiple places in the class. This patch reorganizes
them so that they are maintained solely by text node related functions/code.

The following three members are used only in text node handling, but are
initialized/reset at multiple places. This patch moves their init/reset to
HandleTextNode() since HandleTextNode() is called only once for each text node.
- offset_
- handled_first_letter_
- first_letter_text_

The following member is used only when deciding whether there is a whitespace
at the end of a text node that should be emitted, but hasn't been emitted during
the handling of the node. Since its use is limited at two places, it should also
be reset at those two places.
- last_text_node_ends_with_collapsed_space_

BUG=721957
TEST=n/a; shouldn't have any behavioral change
==========

[yosin_UTC9, 2017-05-25 04:51:59]

rs lgtm

[yosin_UTC9, 2017-05-25 04:52:00]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-05-25 04:52:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 04:52:16]

This CL has an open dependency (Issue 2902683005 Patch 80001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Xiaocheng, 2017-05-25 05:33:22]

Thanks for reviewing.

Postponed to M61 in case of regressions.

[Xiaocheng, 2017-05-25 20:36:27]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 20:37:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-25 20:58:24]

Whoops, I should have run layout tests locally before uploading...

The reorganization of last_text_node_ends_with_collapsed_space_ is not
successful yet. There are some scenarios where it should be cleared but not.

Fixing...

[Xiaocheng, 2017-05-25 22:34:59]

Description was changed from

==========
Reorganize the maintenance of several text node related members in TextIterator

Some members of TextIterator are used only by text node related functions, but
are initialized/reset at multiple places in the class. This patch reorganizes
them so that they are maintained solely by text node related functions/code.

The following three members are used only in text node handling, but are
initialized/reset at multiple places. This patch moves their init/reset to
HandleTextNode() since HandleTextNode() is called only once for each text node.
- offset_
- handled_first_letter_
- first_letter_text_

The following member is used only when deciding whether there is a whitespace
at the end of a text node that should be emitted, but hasn't been emitted during
the handling of the node. Since its use is limited at two places, it should also
be reset at those two places.
- last_text_node_ends_with_collapsed_space_

BUG=721957
TEST=n/a; shouldn't have any behavioral change
==========

to

==========
Reorganize the maintenance of several text node related members in TextIterator

Some members of TextIterator are used only by text node related functions, but
are initialized/reset at multiple places in the class. This patch reorganizes
them so that they are maintained solely by text node related functions/code.
- offset_
- handled_first_letter_
- first_letter_text_

BUG=721957
TEST=n/a; shouldn't have any behavioral change
==========

[Xiaocheng, 2017-05-25 22:35:15]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 22:36:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-25 22:36:56]

I finally decided not to touch whitespace fixup code
(last_text_node_ended_with_collapsed_space_).

It's maintenance is too hacky and can't be properly encapsulated. Instead, I'm
going to wrap its maintenance by the wrapper class, so that when switching to
LayoutNG, the wrapper function can be replaced by no-op.

[commit-bot: I haz the power, 2017-05-26 00:39:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 00:39:29]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-05-26 21:51:54]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 21:52:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 21:57:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 21:57:42]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-05-26 23:56:21]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2017-05-26 23:56:22]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2896023003/#ps100001
(title: "Thu May 25 15:15:18 PDT 2017")

[commit-bot: I haz the power, 2017-05-26 23:56:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-27 00:06:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-27 00:06:23]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Xiaocheng, 2017-05-27 02:47:27]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-27 02:47:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-27 03:14:56]

The CQ bit was unchecked by xiaochengh@chromium.org

[Xiaocheng, 2017-05-27 03:14:59]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2017-05-27 03:15:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-27 03:23:12]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495854899527080,
"parent_rev": "ff8d8838d10847c5c41b7e7bc6ee488ccebbcda2", "commit_rev":
"2d8f80cfe9a0069c01a44d3f209b69e5186da2fc"}

[commit-bot: I haz the power, 2017-05-27 03:23:24]

Description was changed from

==========
Reorganize the maintenance of several text node related members in TextIterator

Some members of TextIterator are used only by text node related functions, but
are initialized/reset at multiple places in the class. This patch reorganizes
them so that they are maintained solely by text node related functions/code.
- offset_
- handled_first_letter_
- first_letter_text_

BUG=721957
TEST=n/a; shouldn't have any behavioral change
==========

to

==========
Reorganize the maintenance of several text node related members in TextIterator

Some members of TextIterator are used only by text node related functions, but
are initialized/reset at multiple places in the class. This patch reorganizes
them so that they are maintained solely by text node related functions/code.
- offset_
- handled_first_letter_
- first_letter_text_

BUG=721957
TEST=n/a; shouldn't have any behavioral change

Review-Url: https://codereview.chromium.org/2896023003
Cr-Commit-Position: refs/heads/master@{#475231}
Committed:
https://chromium.googlesource.com/chromium/src/+/2d8f80cfe9a0069c01a44d3f209b...
==========

[commit-bot: I haz the power, 2017-05-27 03:23:24]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/2d8f80cfe9a0069c01a44d3f209b...