Add member TextIterator::text_node_

Add member TextIterator::text_node_

This patch adds a new member TextIterator::text_node_ to record
the text node that is being handled in TextIterator. As a result,
text node handling and the remaining part of TextIterator share one
less member, so that the encapsulation of text node handling is
easier. 

BUG=721957
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2902173003
Cr-Commit-Position: refs/heads/master@{#475237}
Committed: https://chromium.googlesource.com/chromium/src/+/b109b249a23d3146575b12b1fa4781ade53dac28

[Xiaocheng, 2017-05-25 05:36:54]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 05:37:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-25 05:38:45]

Description was changed from

==========
Add member TextIterator::text_node_

BUG=
==========

to

==========
Add member TextIterator::text_node_

This patch adds a new member TextIterator::text_node_ to record
the text node that is being handled in TextIterator. As a result,
text node handling and the remaining part of TextIterator share one
less member, so that the encapsulation of text node handling is
easier. 

BUG=721957
TEST=n/a; no behavioral change
==========

[Xiaocheng, 2017-05-25 05:38:52]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-05-25 05:38:53]

PTAL.

[yosin_UTC9, 2017-05-25 05:46:50]

lgtm

How about introducing TextNodeIteator which has
- text_node_;
- offset_
- handled_first_letter_
- first_letter_text_
etc found in [1].

Then make TI construct TextNodeIterator when TI visits Text node to replace
reset there members by ctor of TextNodeIteator.

In this way, we can easily introduce Layout NG version of TextNodeIteator.



[1] http://crrev.com/896023003: POSTPONED TO M61 Reorganize the maintenance of
several text node related members in TextIterator

[Xiaocheng, 2017-05-25 05:50:30]

On 2017/05/25 at 05:46:50, yosin wrote:
> lgtm

Thanks!

> 
> How about introducing TextNodeIteator which has
> - text_node_;
> - offset_
> - handled_first_letter_
> - first_letter_text_
> etc found in [1].
> 
> Then make TI construct TextNodeIterator when TI visits Text node to replace
> reset there members by ctor of TextNodeIteator.
> 
> In this way, we can easily introduce Layout NG version of TextNodeIteator.

Yeah, that's exactly what I'm going to introduce at the end.

The only thing I'm not sure about is the name of this class...

> 
> 
> 
> [1] http://crrev.com/896023003: POSTPONED TO M61 Reorganize the maintenance of
several text node related members in TextIterator

[commit-bot: I haz the power, 2017-05-25 09:08:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 09:08:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xiaocheng, 2017-05-25 23:02:32]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 23:03:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 01:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 01:19:33]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-05-26 21:52:02]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 21:53:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 21:58:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 21:58:15]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-05-27 02:47:44]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-27 02:47:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-27 03:26:28]

The CQ bit was unchecked by xiaochengh@chromium.org

[Xiaocheng, 2017-05-27 03:26:31]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2017-05-27 03:26:32]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2902173003/#ps40001
(title: "Wed May 24 22:35:30 PDT 2017")

[commit-bot: I haz the power, 2017-05-27 03:26:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-27 05:04:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495855591663700,
"parent_rev": "8823fc31cc8bf4a2033326d7214e77963ea74977", "commit_rev":
"b109b249a23d3146575b12b1fa4781ade53dac28"}

[commit-bot: I haz the power, 2017-05-27 05:04:38]

Description was changed from

==========
Add member TextIterator::text_node_

This patch adds a new member TextIterator::text_node_ to record
the text node that is being handled in TextIterator. As a result,
text node handling and the remaining part of TextIterator share one
less member, so that the encapsulation of text node handling is
easier. 

BUG=721957
TEST=n/a; no behavioral change
==========

to

==========
Add member TextIterator::text_node_

This patch adds a new member TextIterator::text_node_ to record
the text node that is being handled in TextIterator. As a result,
text node handling and the remaining part of TextIterator share one
less member, so that the encapsulation of text node handling is
easier. 

BUG=721957
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2902173003
Cr-Commit-Position: refs/heads/master@{#475237}
Committed:
https://chromium.googlesource.com/chromium/src/+/b109b249a23d3146575b12b1fa47...
==========

[commit-bot: I haz the power, 2017-05-27 05:04:39]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b109b249a23d3146575b12b1fa47...