Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2895733002: DevTools: remove unused UI related code (Closed)

Created:
3 years, 7 months ago by luoe
Modified:
3 years, 7 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove unused UI related code BUG=none Review-Url: https://codereview.chromium.org/2895733002 Cr-Commit-Position: refs/heads/master@{#473679} Committed: https://chromium.googlesource.com/chromium/src/+/0c4988c82aff00b563b13d66fe10a5e8df9236f4

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -109 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/ContextMenu.js View 1 chunk +0 lines, -2 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js View 2 chunks +0 lines, -101 lines 2 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/KeyboardShortcut.js View 1 chunk +0 lines, -3 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/ui/Panel.js View 1 chunk +0 lines, -3 lines 1 comment Download

Messages

Total messages: 9 (4 generated)
luoe
Please take a look https://codereview.chromium.org/2895733002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/ContextMenu.js File third_party/WebKit/Source/devtools/front_end/ui/ContextMenu.js (left): https://codereview.chromium.org/2895733002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/ContextMenu.js#oldcode391 third_party/WebKit/Source/devtools/front_end/ui/ContextMenu.js:391: UI._contextMenu = this; Added: https://chromium.googlesource.com/chromium/src/+/5189f94c96828d4422412f19411fe469438b8280%5E%21/#F2 ...
3 years, 7 months ago (2017-05-22 17:50:48 UTC) #2
alph
lgtm
3 years, 7 months ago (2017-05-22 18:53:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895733002/1
3 years, 7 months ago (2017-05-22 18:53:38 UTC) #5
luoe
Thanks for the quick review!
3 years, 7 months ago (2017-05-22 18:53:38 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 20:38:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0c4988c82aff00b563b13d66fe10...

Powered by Google App Engine
This is Rietveld 408576698