DevTools: Turn FilterBar into Toolbar in timeline events log view.

DevTools: Turn FilterBar into Toolbar in timeline events log view.

A bit of refactoring as we're moving out of using FilterBar.

Review-Url: https://codereview.chromium.org/2686993002
Cr-Commit-Position: refs/heads/master@{#449420}
Committed: https://chromium.googlesource.com/chromium/src/+/19c5ed5c476666fa7368d00e68dd15c3af7e1140

[alph, 2017-02-09 00:26:28]

alph@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2017-02-09 00:46:04]

lgtm

https://codereview.chromium.org/2686993002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js
(right):

https://codereview.chromium.org/2686993002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js:167:
var label, title;
split into two lines.

https://codereview.chromium.org/2686993002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js:176:
durationFilterUI.addOption(durationFilterUI.createOption(label, title, value));
perhaps just call create option with appropriate labels using a ternary operator
above?

[alph, 2017-02-09 01:01:50]

https://codereview.chromium.org/2686993002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js
(right):

https://codereview.chromium.org/2686993002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js:176:
durationFilterUI.addOption(durationFilterUI.createOption(label, title, value));
On 2017/02/09 00:46:04, caseq wrote:
> perhaps just call create option with appropriate labels using a ternary
operator
> above?

Done.

[alph, 2017-02-09 01:02:35]

The CQ bit was checked by alph@chromium.org

[alph, 2017-02-09 01:02:35]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2686993002/#ps20001
(title: "addressing comment")

[commit-bot: I haz the power, 2017-02-09 01:03:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 02:24:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 02:24:52]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[alph, 2017-02-09 18:18:26]

The CQ bit was checked by alph@chromium.org

[alph, 2017-02-09 18:18:26]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2686993002/#ps40001
(title: "fix test")

[commit-bot: I haz the power, 2017-02-09 18:19:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 18:21:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 18:21:36]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[alph, 2017-02-09 20:02:34]

The CQ bit was checked by alph@chromium.org

[alph, 2017-02-09 20:02:34]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2686993002/#ps60001
(title: "rebaseline")

[commit-bot: I haz the power, 2017-02-09 20:04:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 21:39:24]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486670554350590,
"parent_rev": "8adf20ae3d05c0c8f6409fbaa160c3062d18f8ae", "commit_rev":
"19c5ed5c476666fa7368d00e68dd15c3af7e1140"}

[commit-bot: I haz the power, 2017-02-09 21:39:57]

Description was changed from

==========
DevTools: Turn FilterBar into Toolbar in timeline events log view.

A bit of refactoring as we're moving out of using FilterBar.
==========

to

==========
DevTools: Turn FilterBar into Toolbar in timeline events log view.

A bit of refactoring as we're moving out of using FilterBar.

Review-Url: https://codereview.chromium.org/2686993002
Cr-Commit-Position: refs/heads/master@{#449420}
Committed:
https://chromium.googlesource.com/chromium/src/+/19c5ed5c476666fa7368d00e68dd...
==========

[commit-bot: I haz the power, 2017-02-09 21:39:58]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/19c5ed5c476666fa7368d00e68dd...