Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 33143002: DevTools: Unify filtering UI (Closed)

Created:
7 years, 2 months ago by vsevik
Modified:
7 years, 2 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 10

Patch Set 2 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+953 lines, -628 lines) Patch
M LayoutTests/inspector/network-filter-updated-requests.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/network-toggle-type-filter.html View 1 1 chunk +2 lines, -4 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-filtering.html View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/devtools.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ConsolePanel.js View 2 chunks +0 lines, -13 lines 0 comments Download
M Source/devtools/front_end/ConsoleView.js View 1 9 chunks +84 lines, -193 lines 0 comments Download
A Source/devtools/front_end/FilterBar.js View 1 1 chunk +546 lines, -0 lines 0 comments Download
M Source/devtools/front_end/NetworkPanel.js View 1 15 chunks +46 lines, -130 lines 0 comments Download
M Source/devtools/front_end/Panel.js View 1 chunk +0 lines, -15 lines 0 comments Download
M Source/devtools/front_end/SearchController.js View 9 chunks +2 lines, -75 lines 0 comments Download
M Source/devtools/front_end/Settings.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/TimelinePanel.js View 1 10 chunks +109 lines, -107 lines 0 comments Download
M Source/devtools/front_end/TimelinePresentationModel.js View 1 1 chunk +1 line, -1 line 0 comments Download
A Source/devtools/front_end/filter.css View 1 1 chunk +137 lines, -0 lines 0 comments Download
M Source/devtools/front_end/inspector.css View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/inspector.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/networkPanel.css View 1 3 chunks +9 lines, -10 lines 0 comments Download
M Source/devtools/front_end/profilesPanel.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timelinePanel.css View 1 3 chunks +7 lines, -74 lines 0 comments Download
M Source/devtools/scripts/compile_frontend.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vsevik
Please review
7 years, 2 months ago (2013-10-21 17:16:55 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/33143002/diff/1/Source/devtools/front_end/FilterController.js File Source/devtools/front_end/FilterController.js (right): https://codereview.chromium.org/33143002/diff/1/Source/devtools/front_end/FilterController.js#newcode140 Source/devtools/front_end/FilterController.js:140: WebInspector.TypesFilter = function(types) NamedBitSetFilter https://codereview.chromium.org/33143002/diff/1/Source/devtools/front_end/FilterController.js#newcode153 Source/devtools/front_end/FilterController.js:153: for (var ...
7 years, 2 months ago (2013-10-22 15:15:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/33143002/100001
7 years, 2 months ago (2013-10-23 08:46:51 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=9357
7 years, 2 months ago (2013-10-23 09:58:05 UTC) #4
vsevik
7 years, 2 months ago (2013-10-23 11:54:37 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r160330 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698