Revert of Remove cullRect() from PaintOpBuffer.

Revert of Remove cullRect() from PaintOpBuffer. (patchset #6 id:100001 of https://codereview.chromium.org/2889653002/ )

Reason for revert:
Seems to have introduced a use-of-uninitialized-value, making lots of tests
fail on MSan bots:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests

Original issue's description:
> Remove cullRect() from PaintOpBuffer.
> 
> Pass it directly to RecordPaintCanvas and ToSkPicture, and other skia
> methods which is where it is used.
> 
> This allows us to more easily get rid of cc::DisplayItem and its
> subclasses, replacing them with a PaintOpBuffer in DisplayItemList
> directly instead. The difficulty I faced with that was that if
> DisplayItemList has a single PaintOpBuffer, then it has a single
> cull rect. However when painting, each "batch" of PaintOps can
> have a different cull rect (corresponding to the PaintOps that
> would have been in a single DisplayItem before). So, instead the
> cull rect should be a property of recording at the
> RecordPaintCanvas level, which is a temporary object. As such,
> creators of cc::RecordPaintCanvas (mostly thru cc::PaintRecorder)
> need to manage the cull rect themselves to pass to things that
> want to use it with the cc::PaintOpBuffer (aka cc::PaintRecord at
> this time).
> 
> Original code review was done on gerrit:
> https://chromium-review.googlesource.com/c/503472
> 
> R=chrishtr@chromium.org, enne@chromium.org, pdr@chromium.org
> BUG=671433, 646010
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2889653002 .
> Cr-Commit-Position: refs/heads/master@{#472917}
> Committed: https://chromium.googlesource.com/chromium/src/+/c5f1b6126a7657234b9abc0c4359cbab45850b69

TBR=chrishtr@chromium.org,enne@chromium.org,pdr@chromium.org,danakj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671433, 646010
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2894843002
Cr-Commit-Position: refs/heads/master@{#473164}
Committed: https://chromium.googlesource.com/chromium/src/+/ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9

[Marc Treib, 2017-05-19 09:28:58]

Created Revert of Remove cullRect() from PaintOpBuffer.

[Marc Treib, 2017-05-19 09:33:09]

Description was changed from

==========
Revert of Remove cullRect() from PaintOpBuffer. (patchset #6 id:100001 of
https://codereview.chromium.org/2889653002/ )

Reason for revert:
Seems to have introduced a use-of-uninitialized-value, making lots of tests
fail on MSan bots:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%...
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chrom...

Original issue's description:
> Remove cullRect() from PaintOpBuffer.
> 
> Pass it directly to RecordPaintCanvas and ToSkPicture, and other skia
> methods which is where it is used.
> 
> This allows us to more easily get rid of cc::DisplayItem and its
> subclasses, replacing them with a PaintOpBuffer in DisplayItemList
> directly instead. The difficulty I faced with that was that if
> DisplayItemList has a single PaintOpBuffer, then it has a single
> cull rect. However when painting, each "batch" of PaintOps can
> have a different cull rect (corresponding to the PaintOps that
> would have been in a single DisplayItem before). So, instead the
> cull rect should be a property of recording at the
> RecordPaintCanvas level, which is a temporary object. As such,
> creators of cc::RecordPaintCanvas (mostly thru cc::PaintRecorder)
> need to manage the cull rect themselves to pass to things that
> want to use it with the cc::PaintOpBuffer (aka cc::PaintRecord at
> this time).
> 
> Original code review was done on gerrit:
> https://chromium-review.googlesource.com/c/503472
> 
> R=chrishtr@chromium.org, enne@chromium.org, pdr@chromium.org
> BUG=671433, 646010
>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2889653002 .
> Cr-Commit-Position: refs/heads/master@{#472917}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c5f1b6126a7657234b9abc0c4359...

TBR=chrishtr@chromium.org,enne@chromium.org,pdr@chromium.org,danakj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671433, 646010
==========

to

==========
Revert of Remove cullRect() from PaintOpBuffer. (patchset #6 id:100001 of
https://codereview.chromium.org/2889653002/ )

Reason for revert:
Seems to have introduced a use-of-uninitialized-value, making lots of tests
fail on MSan bots:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%...
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chrom...

Original issue's description:
> Remove cullRect() from PaintOpBuffer.
> 
> Pass it directly to RecordPaintCanvas and ToSkPicture, and other skia
> methods which is where it is used.
> 
> This allows us to more easily get rid of cc::DisplayItem and its
> subclasses, replacing them with a PaintOpBuffer in DisplayItemList
> directly instead. The difficulty I faced with that was that if
> DisplayItemList has a single PaintOpBuffer, then it has a single
> cull rect. However when painting, each "batch" of PaintOps can
> have a different cull rect (corresponding to the PaintOps that
> would have been in a single DisplayItem before). So, instead the
> cull rect should be a property of recording at the
> RecordPaintCanvas level, which is a temporary object. As such,
> creators of cc::RecordPaintCanvas (mostly thru cc::PaintRecorder)
> need to manage the cull rect themselves to pass to things that
> want to use it with the cc::PaintOpBuffer (aka cc::PaintRecord at
> this time).
> 
> Original code review was done on gerrit:
> https://chromium-review.googlesource.com/c/503472
> 
> R=chrishtr@chromium.org, enne@chromium.org, pdr@chromium.org
> BUG=671433, 646010
>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2889653002 .
> Cr-Commit-Position: refs/heads/master@{#472917}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c5f1b6126a7657234b9abc0c4359...

TBR=chrishtr@chromium.org,enne@chromium.org,pdr@chromium.org,danakj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671433, 646010
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Marc Treib, 2017-05-19 09:33:10]

Description was changed from

==========
Revert of Remove cullRect() from PaintOpBuffer. (patchset #6 id:100001 of
https://codereview.chromium.org/2889653002/ )

Reason for revert:
Seems to have introduced a use-of-uninitialized-value, making lots of tests
fail on MSan bots:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%...
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chrom...

Original issue's description:
> Remove cullRect() from PaintOpBuffer.
> 
> Pass it directly to RecordPaintCanvas and ToSkPicture, and other skia
> methods which is where it is used.
> 
> This allows us to more easily get rid of cc::DisplayItem and its
> subclasses, replacing them with a PaintOpBuffer in DisplayItemList
> directly instead. The difficulty I faced with that was that if
> DisplayItemList has a single PaintOpBuffer, then it has a single
> cull rect. However when painting, each "batch" of PaintOps can
> have a different cull rect (corresponding to the PaintOps that
> would have been in a single DisplayItem before). So, instead the
> cull rect should be a property of recording at the
> RecordPaintCanvas level, which is a temporary object. As such,
> creators of cc::RecordPaintCanvas (mostly thru cc::PaintRecorder)
> need to manage the cull rect themselves to pass to things that
> want to use it with the cc::PaintOpBuffer (aka cc::PaintRecord at
> this time).
> 
> Original code review was done on gerrit:
> https://chromium-review.googlesource.com/c/503472
> 
> R=chrishtr@chromium.org, enne@chromium.org, pdr@chromium.org
> BUG=671433, 646010
>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2889653002 .
> Cr-Commit-Position: refs/heads/master@{#472917}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c5f1b6126a7657234b9abc0c4359...

TBR=chrishtr@chromium.org,enne@chromium.org,pdr@chromium.org,danakj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671433, 646010
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Revert of Remove cullRect() from PaintOpBuffer. (patchset #6 id:100001 of
https://codereview.chromium.org/2889653002/ )

Reason for revert:
Seems to have introduced a use-of-uninitialized-value, making lots of tests
fail on MSan bots:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%...
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chrom...

Original issue's description:
> Remove cullRect() from PaintOpBuffer.
> 
> Pass it directly to RecordPaintCanvas and ToSkPicture, and other skia
> methods which is where it is used.
> 
> This allows us to more easily get rid of cc::DisplayItem and its
> subclasses, replacing them with a PaintOpBuffer in DisplayItemList
> directly instead. The difficulty I faced with that was that if
> DisplayItemList has a single PaintOpBuffer, then it has a single
> cull rect. However when painting, each "batch" of PaintOps can
> have a different cull rect (corresponding to the PaintOps that
> would have been in a single DisplayItem before). So, instead the
> cull rect should be a property of recording at the
> RecordPaintCanvas level, which is a temporary object. As such,
> creators of cc::RecordPaintCanvas (mostly thru cc::PaintRecorder)
> need to manage the cull rect themselves to pass to things that
> want to use it with the cc::PaintOpBuffer (aka cc::PaintRecord at
> this time).
> 
> Original code review was done on gerrit:
> https://chromium-review.googlesource.com/c/503472
> 
> R=chrishtr@chromium.org, enne@chromium.org, pdr@chromium.org
> BUG=671433, 646010
>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2889653002 .
> Cr-Commit-Position: refs/heads/master@{#472917}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c5f1b6126a7657234b9abc0c4359...

TBR=chrishtr@chromium.org,enne@chromium.org,pdr@chromium.org,danakj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671433, 646010
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Marc Treib, 2017-05-19 09:33:29]

Description was changed from

==========
Revert of Remove cullRect() from PaintOpBuffer. (patchset #6 id:100001 of
https://codereview.chromium.org/2889653002/ )

Reason for revert:
Seems to have introduced a use-of-uninitialized-value, making lots of tests
fail on MSan bots:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%...
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chrom...

Original issue's description:
> Remove cullRect() from PaintOpBuffer.
> 
> Pass it directly to RecordPaintCanvas and ToSkPicture, and other skia
> methods which is where it is used.
> 
> This allows us to more easily get rid of cc::DisplayItem and its
> subclasses, replacing them with a PaintOpBuffer in DisplayItemList
> directly instead. The difficulty I faced with that was that if
> DisplayItemList has a single PaintOpBuffer, then it has a single
> cull rect. However when painting, each "batch" of PaintOps can
> have a different cull rect (corresponding to the PaintOps that
> would have been in a single DisplayItem before). So, instead the
> cull rect should be a property of recording at the
> RecordPaintCanvas level, which is a temporary object. As such,
> creators of cc::RecordPaintCanvas (mostly thru cc::PaintRecorder)
> need to manage the cull rect themselves to pass to things that
> want to use it with the cc::PaintOpBuffer (aka cc::PaintRecord at
> this time).
> 
> Original code review was done on gerrit:
> https://chromium-review.googlesource.com/c/503472
> 
> R=chrishtr@chromium.org, enne@chromium.org, pdr@chromium.org
> BUG=671433, 646010
>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2889653002 .
> Cr-Commit-Position: refs/heads/master@{#472917}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c5f1b6126a7657234b9abc0c4359...

TBR=chrishtr@chromium.org,enne@chromium.org,pdr@chromium.org,danakj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671433, 646010
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Revert of Remove cullRect() from PaintOpBuffer. (patchset #6 id:100001 of
https://codereview.chromium.org/2889653002/ )

Reason for revert:
Seems to have introduced a use-of-uninitialized-value, making lots of tests
fail on MSan bots:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%...
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chrom...

Original issue's description:
> Remove cullRect() from PaintOpBuffer.
> 
> Pass it directly to RecordPaintCanvas and ToSkPicture, and other skia
> methods which is where it is used.
> 
> This allows us to more easily get rid of cc::DisplayItem and its
> subclasses, replacing them with a PaintOpBuffer in DisplayItemList
> directly instead. The difficulty I faced with that was that if
> DisplayItemList has a single PaintOpBuffer, then it has a single
> cull rect. However when painting, each "batch" of PaintOps can
> have a different cull rect (corresponding to the PaintOps that
> would have been in a single DisplayItem before). So, instead the
> cull rect should be a property of recording at the
> RecordPaintCanvas level, which is a temporary object. As such,
> creators of cc::RecordPaintCanvas (mostly thru cc::PaintRecorder)
> need to manage the cull rect themselves to pass to things that
> want to use it with the cc::PaintOpBuffer (aka cc::PaintRecord at
> this time).
> 
> Original code review was done on gerrit:
> https://chromium-review.googlesource.com/c/503472
> 
> R=chrishtr@chromium.org, enne@chromium.org, pdr@chromium.org
> BUG=671433, 646010
>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2889653002 .
> Cr-Commit-Position: refs/heads/master@{#472917}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c5f1b6126a7657234b9abc0c4359...

TBR=chrishtr@chromium.org,enne@chromium.org,pdr@chromium.org,danakj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=671433, 646010
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Marc Treib, 2017-05-19 09:33:39]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 09:33:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-05-19 09:40:35]

I had to manually resolve some (trivial) conflicts with
https://codereview.chromium.org/2893803002 in FrameThrottlingTest.cpp, so
sending this through the CQ just to be safe.

[commit-bot: I haz the power, 2017-05-19 10:09:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 10:09:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marc Treib, 2017-05-19 10:18:17]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 10:18:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-05-19 11:55:02]

Description was changed from

==========
Revert of Remove cullRect() from PaintOpBuffer. (patchset #6 id:100001 of
https://codereview.chromium.org/2889653002/ )

Reason for revert:
Seems to have introduced a use-of-uninitialized-value, making lots of tests
fail on MSan bots:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%...
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chrom...

Original issue's description:
> Remove cullRect() from PaintOpBuffer.
> 
> Pass it directly to RecordPaintCanvas and ToSkPicture, and other skia
> methods which is where it is used.
> 
> This allows us to more easily get rid of cc::DisplayItem and its
> subclasses, replacing them with a PaintOpBuffer in DisplayItemList
> directly instead. The difficulty I faced with that was that if
> DisplayItemList has a single PaintOpBuffer, then it has a single
> cull rect. However when painting, each "batch" of PaintOps can
> have a different cull rect (corresponding to the PaintOps that
> would have been in a single DisplayItem before). So, instead the
> cull rect should be a property of recording at the
> RecordPaintCanvas level, which is a temporary object. As such,
> creators of cc::RecordPaintCanvas (mostly thru cc::PaintRecorder)
> need to manage the cull rect themselves to pass to things that
> want to use it with the cc::PaintOpBuffer (aka cc::PaintRecord at
> this time).
> 
> Original code review was done on gerrit:
> https://chromium-review.googlesource.com/c/503472
> 
> R=chrishtr@chromium.org, enne@chromium.org, pdr@chromium.org
> BUG=671433, 646010
>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2889653002 .
> Cr-Commit-Position: refs/heads/master@{#472917}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c5f1b6126a7657234b9abc0c4359...

TBR=chrishtr@chromium.org,enne@chromium.org,pdr@chromium.org,danakj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=671433, 646010
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Revert of Remove cullRect() from PaintOpBuffer. (patchset #6 id:100001 of
https://codereview.chromium.org/2889653002/ )

Reason for revert:
Seems to have introduced a use-of-uninitialized-value, making lots of tests
fail on MSan bots:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%...
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chrom...

Original issue's description:
> Remove cullRect() from PaintOpBuffer.
> 
> Pass it directly to RecordPaintCanvas and ToSkPicture, and other skia
> methods which is where it is used.
> 
> This allows us to more easily get rid of cc::DisplayItem and its
> subclasses, replacing them with a PaintOpBuffer in DisplayItemList
> directly instead. The difficulty I faced with that was that if
> DisplayItemList has a single PaintOpBuffer, then it has a single
> cull rect. However when painting, each "batch" of PaintOps can
> have a different cull rect (corresponding to the PaintOps that
> would have been in a single DisplayItem before). So, instead the
> cull rect should be a property of recording at the
> RecordPaintCanvas level, which is a temporary object. As such,
> creators of cc::RecordPaintCanvas (mostly thru cc::PaintRecorder)
> need to manage the cull rect themselves to pass to things that
> want to use it with the cc::PaintOpBuffer (aka cc::PaintRecord at
> this time).
> 
> Original code review was done on gerrit:
> https://chromium-review.googlesource.com/c/503472
> 
> R=chrishtr@chromium.org, enne@chromium.org, pdr@chromium.org
> BUG=671433, 646010
>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2889653002 .
> Cr-Commit-Position: refs/heads/master@{#472917}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c5f1b6126a7657234b9abc0c4359...

TBR=chrishtr@chromium.org,enne@chromium.org,pdr@chromium.org,danakj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671433, 646010
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Marc Treib, 2017-05-19 11:55:59]

On 2017/05/19 09:40:35, Marc Treib wrote:
> I had to manually resolve some (trivial) conflicts with
> https://codereview.chromium.org/2893803002 in FrameThrottlingTest.cpp, so
> sending this through the CQ just to be safe.

Okay, trybots seem to be fine in PS3 except for missing NeedsRebaselines.
Landing with NOTRY now.

[Marc Treib, 2017-05-19 12:04:14]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2017-05-19 12:04:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 12:05:58]

CQ is committing da patch.

Bot data: {"patchset_id": 330001, "attempt_start_ts": 1495195454498660,
"parent_rev": "8e46baf867a845e459199e2aefa358ee1e26a559", "commit_rev":
"ba67e74fd455e9f581c1cffc503a2ad10e4e5fa9"}

[commit-bot: I haz the power, 2017-05-19 12:06:11]

Description was changed from

==========
Revert of Remove cullRect() from PaintOpBuffer. (patchset #6 id:100001 of
https://codereview.chromium.org/2889653002/ )

Reason for revert:
Seems to have introduced a use-of-uninitialized-value, making lots of tests
fail on MSan bots:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%...
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chrom...

Original issue's description:
> Remove cullRect() from PaintOpBuffer.
> 
> Pass it directly to RecordPaintCanvas and ToSkPicture, and other skia
> methods which is where it is used.
> 
> This allows us to more easily get rid of cc::DisplayItem and its
> subclasses, replacing them with a PaintOpBuffer in DisplayItemList
> directly instead. The difficulty I faced with that was that if
> DisplayItemList has a single PaintOpBuffer, then it has a single
> cull rect. However when painting, each "batch" of PaintOps can
> have a different cull rect (corresponding to the PaintOps that
> would have been in a single DisplayItem before). So, instead the
> cull rect should be a property of recording at the
> RecordPaintCanvas level, which is a temporary object. As such,
> creators of cc::RecordPaintCanvas (mostly thru cc::PaintRecorder)
> need to manage the cull rect themselves to pass to things that
> want to use it with the cc::PaintOpBuffer (aka cc::PaintRecord at
> this time).
> 
> Original code review was done on gerrit:
> https://chromium-review.googlesource.com/c/503472
> 
> R=chrishtr@chromium.org, enne@chromium.org, pdr@chromium.org
> BUG=671433, 646010
>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2889653002 .
> Cr-Commit-Position: refs/heads/master@{#472917}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c5f1b6126a7657234b9abc0c4359...

TBR=chrishtr@chromium.org,enne@chromium.org,pdr@chromium.org,danakj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671433, 646010
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Revert of Remove cullRect() from PaintOpBuffer. (patchset #6 id:100001 of
https://codereview.chromium.org/2889653002/ )

Reason for revert:
Seems to have introduced a use-of-uninitialized-value, making lots of tests
fail on MSan bots:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%...
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chrom...

Original issue's description:
> Remove cullRect() from PaintOpBuffer.
> 
> Pass it directly to RecordPaintCanvas and ToSkPicture, and other skia
> methods which is where it is used.
> 
> This allows us to more easily get rid of cc::DisplayItem and its
> subclasses, replacing them with a PaintOpBuffer in DisplayItemList
> directly instead. The difficulty I faced with that was that if
> DisplayItemList has a single PaintOpBuffer, then it has a single
> cull rect. However when painting, each "batch" of PaintOps can
> have a different cull rect (corresponding to the PaintOps that
> would have been in a single DisplayItem before). So, instead the
> cull rect should be a property of recording at the
> RecordPaintCanvas level, which is a temporary object. As such,
> creators of cc::RecordPaintCanvas (mostly thru cc::PaintRecorder)
> need to manage the cull rect themselves to pass to things that
> want to use it with the cc::PaintOpBuffer (aka cc::PaintRecord at
> this time).
> 
> Original code review was done on gerrit:
> https://chromium-review.googlesource.com/c/503472
> 
> R=chrishtr@chromium.org, enne@chromium.org, pdr@chromium.org
> BUG=671433, 646010
>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2889653002 .
> Cr-Commit-Position: refs/heads/master@{#472917}
> Committed:
https://chromium.googlesource.com/chromium/src/+/c5f1b6126a7657234b9abc0c4359...

TBR=chrishtr@chromium.org,enne@chromium.org,pdr@chromium.org,danakj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671433, 646010
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2894843002
Cr-Commit-Position: refs/heads/master@{#473164}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba67e74fd455e9f581c1cffc503a...
==========

[commit-bot: I haz the power, 2017-05-19 12:06:13]

Committed patchset #5 (id:330001) as
https://chromium.googlesource.com/chromium/src/+/ba67e74fd455e9f581c1cffc503a...