Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2893803002:
Fix DCHECK failure when PaintLayerContents() paints layer in throttled frame (Closed)
|
Created:
3 years, 7 months ago by Xianzhu Modified:
3 years, 7 months ago Reviewers:
chrishtr CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix DCHECK failure when PaintLayerContents() paints layer in throttled frame
Move the early return for throttled frame above the DCHECK about self-painting
layer status.
BUG=723014
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2893803002
Cr-Commit-Position: refs/heads/master@{#473095}
Committed: https://chromium.googlesource.com/chromium/src/+/b0f1618f1c3f17a71ae3eb538bb326d329869309
Patch Set 1 #Patch Set 2 : - #Patch Set 3 : - #Patch Set 4 : Rebase #
Messages
Total messages: 30 (22 generated)
Description was changed from ========== Don't paint composited layers in a throttled frame BUG=723014 ========== to ========== Don't paint composited layers in a throttled frame BUG=723014 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Don't paint composited layers in a throttled frame BUG=723014 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Fix DCHECK failure when PaintLayerContents() paints layer in throttled frame Move the early return for throttled frame above the DCHECK about self-painting layer status. BUG=723014 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
wangxianzhu@chromium.org changed reviewers: + chrishtr@chromium.org
lgtm
The CQ bit was unchecked by wangxianzhu@chromium.org
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by wangxianzhu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from chrishtr@chromium.org Link to the patchset: https://codereview.chromium.org/2893803002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495164763033740,
"parent_rev": "870290f623b47e436d231e354c84b8723bb7000a", "commit_rev":
"b0f1618f1c3f17a71ae3eb538bb326d329869309"}
Message was sent while issue was closed.
Description was changed from ========== Fix DCHECK failure when PaintLayerContents() paints layer in throttled frame Move the early return for throttled frame above the DCHECK about self-painting layer status. BUG=723014 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Fix DCHECK failure when PaintLayerContents() paints layer in throttled frame Move the early return for throttled frame above the DCHECK about self-painting layer status. BUG=723014 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2893803002 Cr-Commit-Position: refs/heads/master@{#473095} Committed: https://chromium.googlesource.com/chromium/src/+/b0f1618f1c3f17a71ae3eb538bb3... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/b0f1618f1c3f17a71ae3eb538bb3... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
