Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2894773003: [inspector] Merge InspectorClientImpl into IsolateData (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
kozy
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] Merge InspectorClientImpl into IsolateData BUG=none Review-Url: https://codereview.chromium.org/2894773003 Cr-Commit-Position: refs/heads/master@{#45441} Committed: https://chromium.googlesource.com/v8/v8/+/afbaedc8a5cffc36d1faccba1401c61783092d45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -384 lines) Patch
M test/inspector/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M test/inspector/inspector.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D test/inspector/inspector-impl.h View 1 chunk +0 lines, -84 lines 0 comments Download
D test/inspector/inspector-impl.cc View 1 chunk +0 lines, -254 lines 0 comments Download
M test/inspector/inspector-test.cc View 15 chunks +17 lines, -22 lines 0 comments Download
M test/inspector/isolate-data.h View 4 chunks +66 lines, -6 lines 0 comments Download
M test/inspector/isolate-data.cc View 5 chunks +226 lines, -6 lines 0 comments Download
M test/inspector/task-runner.h View 2 chunks +2 lines, -2 lines 0 comments Download
M test/inspector/task-runner.cc View 3 chunks +4 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
dgozman
Take a look please.
3 years, 7 months ago (2017-05-19 19:51:45 UTC) #4
kozy
lgtm
3 years, 7 months ago (2017-05-21 19:30:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894773003/1
3 years, 7 months ago (2017-05-22 00:18:20 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 00:48:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/afbaedc8a5cffc36d1faccba1401c617830...

Powered by Google App Engine
This is Rietveld 408576698