[inspector] Refactor protocol-test.js

[inspector] Refactor protocol-test.js

This refactoring makes it easier to write advanced tests and
gives full control over what's happening to the test code.
It also forces description for every test.

BUG=none

Review-Url: https://codereview.chromium.org/2891213002
Cr-Commit-Position: refs/heads/master@{#45412}
Committed: https://chromium.googlesource.com/v8/v8/+/7bbea08f669df4f6dee69cd7b0629959ca372a37

[dgozman, 2017-05-18 22:21:21]

dgozman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[dgozman, 2017-05-18 22:21:22]

Could you please take a look?

[kozy, 2017-05-18 23:44:54]

lgtm!

https://codereview.chromium.org/2891213002/diff/1/test/inspector/console/dest...
File test/inspector/console/destroy-context-during-log.js (right):

https://codereview.chromium.org/2891213002/diff/1/test/inspector/console/dest...
test/inspector/console/destroy-context-during-log.js:5: let {session,
contextGroup, Protocol} = InspectorTest.start('Tests that destroying context
from inside of console.log does not crash');
If you already have a script, could you change it to:
let {session, contextGroup, Protocol}
  = InspectorTest.start..

to not exceed 80 characters line limit.

https://codereview.chromium.org/2891213002/diff/1/test/inspector/debugger/des...
File test/inspector/debugger/destory-in-break-program.js (right):

https://codereview.chromium.org/2891213002/diff/1/test/inspector/debugger/des...
test/inspector/debugger/destory-in-break-program.js:12:
InspectorTest.quitImmediately();3
3!!!!

https://codereview.chromium.org/2891213002/diff/1/test/inspector/runtime/eval...
File test/inspector/runtime/evaluate-async-with-wrap-error.js (right):

https://codereview.chromium.org/2891213002/diff/1/test/inspector/runtime/eval...
test/inspector/runtime/evaluate-async-with-wrap-error.js:5: let {session,
contextGroup, Protocol} = InspectorTest.start("Test that Runtime.evaluate
correctly process errors during wrapping \
please split it to not exceed 80 characters or just merge it.

[dgozman, 2017-05-19 00:02:45]

https://codereview.chromium.org/2891213002/diff/1/test/inspector/console/dest...
File test/inspector/console/destroy-context-during-log.js (right):

https://codereview.chromium.org/2891213002/diff/1/test/inspector/console/dest...
test/inspector/console/destroy-context-during-log.js:5: let {session,
contextGroup, Protocol} = InspectorTest.start('Tests that destroying context
from inside of console.log does not crash');
On 2017/05/18 23:44:54, kozy wrote:
> If you already have a script, could you change it to:
> let {session, contextGroup, Protocol}
>   = InspectorTest.start..
> 
> to not exceed 80 characters line limit.

Acknowledged.

https://codereview.chromium.org/2891213002/diff/1/test/inspector/debugger/des...
File test/inspector/debugger/destory-in-break-program.js (right):

https://codereview.chromium.org/2891213002/diff/1/test/inspector/debugger/des...
test/inspector/debugger/destory-in-break-program.js:12:
InspectorTest.quitImmediately();3
On 2017/05/18 23:44:54, kozy wrote:
> 3!!!!

Done.

https://codereview.chromium.org/2891213002/diff/1/test/inspector/runtime/eval...
File test/inspector/runtime/evaluate-async-with-wrap-error.js (right):

https://codereview.chromium.org/2891213002/diff/1/test/inspector/runtime/eval...
test/inspector/runtime/evaluate-async-with-wrap-error.js:5: let {session,
contextGroup, Protocol} = InspectorTest.start("Test that Runtime.evaluate
correctly process errors during wrapping \
On 2017/05/18 23:44:54, kozy wrote:
> please split it to not exceed 80 characters or just merge it.

Done.

[dgozman, 2017-05-19 00:02:53]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-05-19 00:02:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org
Link to the patchset: https://codereview.chromium.org/2891213002/#ps20001
(title: "comments addressed")

[commit-bot: I haz the power, 2017-05-19 00:03:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 00:35:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495152173180400,
"parent_rev": "47702c53bc7f2562c73bb73474e73e4d1dd1bb7d", "commit_rev":
"7bbea08f669df4f6dee69cd7b0629959ca372a37"}

[commit-bot: I haz the power, 2017-05-19 00:35:53]

Description was changed from

==========
[inspector] Refactor protocol-test.js

This refactoring makes it easier to write advanced tests and
gives full control over what's happening to the test code.
It also forces description for every test.

BUG=none
==========

to

==========
[inspector] Refactor protocol-test.js

This refactoring makes it easier to write advanced tests and
gives full control over what's happening to the test code.
It also forces description for every test.

BUG=none

Review-Url: https://codereview.chromium.org/2891213002
Cr-Commit-Position: refs/heads/master@{#45412}
Committed:
https://chromium.googlesource.com/v8/v8/+/7bbea08f669df4f6dee69cd7b0629959ca3...
==========

[commit-bot: I haz the power, 2017-05-19 00:35:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/7bbea08f669df4f6dee69cd7b0629959ca3...