Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2901523003: [inspector] Cleanup inspector test (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
kozy
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] Cleanup inspector test - reduce boilerplate; - encapsulate V8Inspector inside IsolateData; - remove extra interfaces and classes. BUG=none Review-Url: https://codereview.chromium.org/2901523003 Cr-Commit-Position: refs/heads/master@{#45470} Committed: https://chromium.googlesource.com/v8/v8/+/93c12e5d3fe2a66d9042710032899448fc76d581

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -440 lines) Patch
M test/inspector/inspector-test.cc View 19 chunks +243 lines, -242 lines 0 comments Download
M test/inspector/isolate-data.h View 4 chunks +9 lines, -12 lines 0 comments Download
M test/inspector/isolate-data.cc View 5 chunks +28 lines, -33 lines 0 comments Download
M test/inspector/task-runner.h View 3 chunks +4 lines, -56 lines 0 comments Download
M test/inspector/task-runner.cc View 6 chunks +6 lines, -97 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
dgozman
Could you please take a look?
3 years, 7 months ago (2017-05-22 18:11:54 UTC) #4
kozy
lgtm
3 years, 7 months ago (2017-05-22 19:49:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901523003/1
3 years, 7 months ago (2017-05-22 20:45:09 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 20:46:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/93c12e5d3fe2a66d9042710032899448fc7...

Powered by Google App Engine
This is Rietveld 408576698