The CQ bit was checked by bnc@chromium.org
Created Revert of Return Request as unique_ptr from JobController::Start().
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1495148846954050, "parent_rev": "6a77bbc3b1aa49c3fd821b5b793b79dc1c4e80c9", "commit_rev": "2708a58f9e5004527b4909e9f03d3df8aa06d633"}
Description was changed from ========== Revert of Return Request as unique_ptr from JobController::Start(). (patchset #1 id:1 of https://codereview.chromium.org/2893713004/ ) Reason for revert: Reverting due to compile failures on the following builders: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2Fios-devic... https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2Fios-devic... https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FAndro... https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FAndro... Original issue's description: > Return Request as unique_ptr from JobController::Start(). > > Return HttpStreamFactoryImpl::Request as std::unique_ptr from > JobController::Start() and up through all callers. It was ultimately > put into a std::unique_ptr already through every call path. > > Also add and remove some unrelated standard library includes as needed. > > BUG=475060 > > Review-Url: https://codereview.chromium.org/2893713004 > Cr-Commit-Position: refs/heads/master@{#472960} > Committed: https://chromium.googlesource.com/chromium/src/+/0864962daa92e2628e33148e4d9a... TBR=rch@chromium.org,zhongyi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=475060 ========== to ========== Revert of Return Request as unique_ptr from JobController::Start(). (patchset #1 id:1 of https://codereview.chromium.org/2893713004/ ) Reason for revert: Reverting due to compile failures on the following builders: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2Fios-devic... https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2Fios-devic... https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FAndro... https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FAndro... Original issue's description: > Return Request as unique_ptr from JobController::Start(). > > Return HttpStreamFactoryImpl::Request as std::unique_ptr from > JobController::Start() and up through all callers. It was ultimately > put into a std::unique_ptr already through every call path. > > Also add and remove some unrelated standard library includes as needed. > > BUG=475060 > > Review-Url: https://codereview.chromium.org/2893713004 > Cr-Commit-Position: refs/heads/master@{#472960} > Committed: https://chromium.googlesource.com/chromium/src/+/0864962daa92e2628e33148e4d9a... TBR=rch@chromium.org,zhongyi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=475060 Review-Url: https://codereview.chromium.org/2894723002 Cr-Commit-Position: refs/heads/master@{#472963} Committed: https://chromium.googlesource.com/chromium/src/+/2708a58f9e5004527b4909e9f03d... ==========
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2708a58f9e5004527b4909e9f03d...
Chromium Code Reviews
Issue
2894723002:
Revert of Return Request as unique_ptr from JobController::Start(). (Closed)
