Return Request as unique_ptr from JobController::Start().

Return Request as unique_ptr from JobController::Start().

Return HttpStreamFactoryImpl::Request as std::unique_ptr from
JobController::Start() and up through all callers.  It was ultimately
put into a std::unique_ptr already through every call path.

Also add and remove some unrelated standard library includes as needed.

BUG=475060
Review-Url: https://codereview.chromium.org/2893713004
Cr-Commit-Position: refs/heads/master@{#472960}
Committed: https://chromium.googlesource.com/chromium/src/+/0864962daa92e2628e33148e4d9a2a41814d9255

[Bence, 2017-05-18 16:38:23]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 16:39:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2017-05-18 17:14:51]

Description was changed from

==========
Return Request as unique_ptr from JobController::Start().

Return HttpStreamFactoryImpl::Request as std::unique_ptr from
JobController::Start() and up through all callers.  It was ultimately
put into a std::unique_ptr already through every call path.

Also add and remove some unrelated standard library includes as needed.
==========

to

==========
Return Request as unique_ptr from JobController::Start().

Return HttpStreamFactoryImpl::Request as std::unique_ptr from
JobController::Start() and up through all callers.  It was ultimately
put into a std::unique_ptr already through every call path.

Also add and remove some unrelated standard library includes as needed.

BUG=475060
==========

[commit-bot: I haz the power, 2017-05-18 18:58:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 18:58:45]

Dry run: This issue passed the CQ dry run.

[Bence, 2017-05-18 19:07:23]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2017-05-18 19:07:23]

Ryan: PTAL.  Thank you.

[Ryan Hamilton, 2017-05-18 21:46:39]

lgtm

Also SWEET!

LGTM

zhongyi: FYI

[Zhongyi Shi, 2017-05-18 21:55:04]

zhongyi@chromium.org changed reviewers:
+ zhongyi@chromium.org

[Zhongyi Shi, 2017-05-18 21:55:05]

lgtm!

FYI: Helen had a proposal(crbug.com/724152) to return a net_error code if
JobController::Start() fails synchronously, which you might consider. But this
change looks good to me, thanks for the clean up!

[Bence, 2017-05-18 22:43:24]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2017-05-18 22:45:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 22:54:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495147404799840, "parent_rev":
"49db099a77be5b377b63e41373840a2b8413e6ff", "commit_rev":
"0864962daa92e2628e33148e4d9a2a41814d9255"}

[commit-bot: I haz the power, 2017-05-18 22:54:29]

Description was changed from

==========
Return Request as unique_ptr from JobController::Start().

Return HttpStreamFactoryImpl::Request as std::unique_ptr from
JobController::Start() and up through all callers.  It was ultimately
put into a std::unique_ptr already through every call path.

Also add and remove some unrelated standard library includes as needed.

BUG=475060
==========

to

==========
Return Request as unique_ptr from JobController::Start().

Return HttpStreamFactoryImpl::Request as std::unique_ptr from
JobController::Start() and up through all callers.  It was ultimately
put into a std::unique_ptr already through every call path.

Also add and remove some unrelated standard library includes as needed.

BUG=475060

Review-Url: https://codereview.chromium.org/2893713004
Cr-Commit-Position: refs/heads/master@{#472960}
Committed:
https://chromium.googlesource.com/chromium/src/+/0864962daa92e2628e33148e4d9a...
==========

[commit-bot: I haz the power, 2017-05-18 22:54:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0864962daa92e2628e33148e4d9a...

[Bence, 2017-05-18 23:07:26]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2894723002/ by bnc@chromium.org.

The reason for reverting is: Reverting due to compile failures on the following
builders:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2Fios-devic...
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2Fios-devic...
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FAndro...
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FAndro....

[findit-for-me, 2017-05-18 23:09:56]

Findit (https://goo.gl/kROfz5) confirmed this CL at revision 472960 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[Bence, 2017-05-18 23:26:22]

Description was changed from

==========
Return Request as unique_ptr from JobController::Start().

Return HttpStreamFactoryImpl::Request as std::unique_ptr from
JobController::Start() and up through all callers.  It was ultimately
put into a std::unique_ptr already through every call path.

Also add and remove some unrelated standard library includes as needed.

BUG=475060

Review-Url: https://codereview.chromium.org/2893713004
Cr-Commit-Position: refs/heads/master@{#472960}
Committed:
https://chromium.googlesource.com/chromium/src/+/0864962daa92e2628e33148e4d9a...
==========

to

==========
Reland of Return Request as unique_ptr from JobController::Start().

Return HttpStreamFactoryImpl::Request as std::unique_ptr from
JobController::Start() and up through all callers.  It was ultimately
put into a std::unique_ptr already through every call path.

Also add and remove some unrelated standard library includes as needed.

BUG=475060

Review-Url: https://codereview.chromium.org/2893713004
Cr-Commit-Position: refs/heads/master@{#472960}
Committed:
https://chromium.googlesource.com/chromium/src/+/0864962daa92e2628e33148e4d9a...
==========

[Bence, 2017-05-18 23:30:13]

Trybots passed a few hours ago.  Then https://crrev.com/2887773006 landed which
added a new test.  Then I checked in this change which broken the build.  So I
reverted.

Now I reopen this CL, fix the compile error, and reland.  Since it's only a
two-line fix, I'm taking the liberty to land without asking for another round of
review, using the previous l-g-t-m.

[Bence, 2017-05-18 23:30:22]

The CQ bit was checked by bnc@chromium.org

[Bence, 2017-05-18 23:30:23]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org,
zhongyi@chromium.org
Link to the patchset: https://codereview.chromium.org/2893713004/#ps20001
(title: "Fix conflict with https://crrev.com/2887773006.")

[commit-bot: I haz the power, 2017-05-18 23:33:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 02:22:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 02:22:38]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Bence, 2017-05-19 16:55:28]

Description was changed from

==========
Reland of Return Request as unique_ptr from JobController::Start().

Return HttpStreamFactoryImpl::Request as std::unique_ptr from
JobController::Start() and up through all callers.  It was ultimately
put into a std::unique_ptr already through every call path.

Also add and remove some unrelated standard library includes as needed.

BUG=475060

Review-Url: https://codereview.chromium.org/2893713004
Cr-Commit-Position: refs/heads/master@{#472960}
Committed:
https://chromium.googlesource.com/chromium/src/+/0864962daa92e2628e33148e4d9a...
==========

to

==========
Return Request as unique_ptr from JobController::Start().

Return HttpStreamFactoryImpl::Request as std::unique_ptr from
JobController::Start() and up through all callers.  It was ultimately
put into a std::unique_ptr already through every call path.

Also add and remove some unrelated standard library includes as needed.

BUG=475060

Review-Url: https://codereview.chromium.org/2893713004
Cr-Commit-Position: refs/heads/master@{#472960}
Committed:
https://chromium.googlesource.com/chromium/src/+/0864962daa92e2628e33148e4d9a...
==========

[Bence, 2017-05-19 16:56:30]

I decided to close this CL after all, and create a new one at
https://crrev.com/2895613002.  Sorry for the confusion.