Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2893713004: Return Request as unique_ptr from JobController::Start(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by Bence
Modified:
1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org, Zhongyi Shi
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Return Request as unique_ptr from JobController::Start(). Return HttpStreamFactoryImpl::Request as std::unique_ptr from JobController::Start() and up through all callers. It was ultimately put into a std::unique_ptr already through every call path. Also add and remove some unrelated standard library includes as needed. BUG=475060 Review-Url: https://codereview.chromium.org/2893713004 Cr-Commit-Position: refs/heads/master@{#472960} Committed: https://chromium.googlesource.com/chromium/src/+/0864962daa92e2628e33148e4d9a2a41814d9255

Patch Set 1 #

Patch Set 2 : Fix conflict with https://crrev.com/2887773006. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -111 lines) Patch
M net/http/bidirectional_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 3 chunks +16 lines, -15 lines 0 comments Download
M net/http/http_stream_factory.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_stream_factory_impl.h View 4 chunks +15 lines, -13 lines 0 comments Download
M net/http/http_stream_factory_impl.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.h View 1 chunk +6 lines, -6 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.cc View 1 3 chunks +9 lines, -5 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller_unittest.cc View 1 28 chunks +56 lines, -54 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 26 (15 generated)
Bence
Ryan: PTAL. Thank you.
1 month ago (2017-05-18 19:07:23 UTC) #7
Ryan Hamilton
lgtm Also SWEET! LGTM zhongyi: FYI
1 month ago (2017-05-18 21:46:39 UTC) #8
Zhongyi Shi
lgtm! FYI: Helen had a proposal(crbug.com/724152) to return a net_error code if JobController::Start() fails synchronously, ...
1 month ago (2017-05-18 21:55:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893713004/1
1 month ago (2017-05-18 22:45:16 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0864962daa92e2628e33148e4d9a2a41814d9255
1 month ago (2017-05-18 22:54:30 UTC) #15
Bence
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2894723002/ by bnc@chromium.org. ...
1 month ago (2017-05-18 23:07:26 UTC) #16
findit-for-me
Findit (https://goo.gl/kROfz5) confirmed this CL at revision 472960 as the culprit for failures in the ...
1 month ago (2017-05-18 23:09:56 UTC) #17
Bence
Trybots passed a few hours ago. Then https://crrev.com/2887773006 landed which added a new test. Then ...
1 month ago (2017-05-18 23:30:13 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893713004/20001
1 month ago (2017-05-18 23:33:28 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/449254)
1 month ago (2017-05-19 02:22:38 UTC) #24
Bence
1 month ago (2017-05-19 16:56:30 UTC) #26
Message was sent while issue was closed.
I decided to close this CL after all, and create a new one at
https://crrev.com/2895613002.  Sorry for the confusion.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318