net/http/http_stream_factory.h - Issue 2894723002: Revert of Return Request as unique_ptr from JobController::Start().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory.h

Issue 2894723002: Revert of Return Request as unique_ptr from JobController::Start(). (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_stream_factory.h

diff --git a/net/http/http_stream_factory.h b/net/http/http_stream_factory.h

index 2c8826a69c0d9fc47eb9773ef5c6edfe6edeb657..be28c0f13c5998cdd98ca93f0a41a33c2b29d26d 100644

--- a/net/http/http_stream_factory.h

+++ b/net/http/http_stream_factory.h

@@ -203,7 +203,7 @@

// Request a stream.

// Will call delegate->OnStreamReady on successful completion.

- virtual std::unique_ptr<HttpStreamRequest> RequestStream(

+ virtual HttpStreamRequest* RequestStream(

const HttpRequestInfo& info,

RequestPriority priority,

const SSLConfig& server_ssl_config,

@@ -216,7 +216,7 @@

// Request a WebSocket handshake stream.

// Will call delegate->OnWebSocketHandshakeStreamReady on successful

// completion.

- virtual std::unique_ptr<HttpStreamRequest> RequestWebSocketHandshakeStream(

+ virtual HttpStreamRequest* RequestWebSocketHandshakeStream(

const HttpRequestInfo& info,

RequestPriority priority,

const SSLConfig& server_ssl_config,

@@ -230,7 +230,7 @@

// Request a BidirectionalStreamImpl.

// Will call delegate->OnBidirectionalStreamImplReady on successful

// completion.

- virtual std::unique_ptr<HttpStreamRequest> RequestBidirectionalStreamImpl(

+ virtual HttpStreamRequest* RequestBidirectionalStreamImpl(

const HttpRequestInfo& info,

RequestPriority priority,

const SSLConfig& server_ssl_config,

« no previous file with comments | « net/http/http_network_transaction_unittest.cc ('k') | net/http/http_stream_factory_impl.h » ('j') | no next file with comments »