Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2894523007: Use display::DisplayMode in ozone/drm/gpu (Closed)

Created:
3 years, 7 months ago by rjkroege
Modified:
3 years, 7 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use display::DisplayMode in the ozone/drm DrmThread boundary to simplify implementing a Mojo interface with the DrmThread interface. BUG=620927 Review-Url: https://codereview.chromium.org/2894523007 Cr-Commit-Position: refs/heads/master@{#474139} Committed: https://chromium.googlesource.com/chromium/src/+/54fee5d86ef41e706cb794d1c587a5269ecee9ec

Patch Set 1 #

Total comments: 6

Patch Set 2 : review nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -37 lines) Patch
M ui/ozone/platform/drm/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/common/drm_util.h View 2 chunks +19 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/common/drm_util.cc View 1 chunk +26 lines, -0 lines 0 comments Download
A ui/ozone/platform/drm/common/drm_util_unittest.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_gpu_display_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc View 4 chunks +17 lines, -12 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_thread.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_thread.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_thread_message_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_thread_message_proxy.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_display_host.cc View 1 chunk +1 line, -12 lines 0 comments Download
M ui/ozone/platform/drm/mus_thread_proxy.cc View 1 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
rjkroege
ptal
3 years, 7 months ago (2017-05-23 18:24:21 UTC) #3
dnicoara
lgtm % nits https://codereview.chromium.org/2894523007/diff/1/ui/ozone/platform/drm/common/drm_util_unittest.cc File ui/ozone/platform/drm/common/drm_util_unittest.cc (right): https://codereview.chromium.org/2894523007/diff/1/ui/ozone/platform/drm/common/drm_util_unittest.cc#newcode5 ui/ozone/platform/drm/common/drm_util_unittest.cc:5: #include "ui/ozone/platform/drm/common/drm_util.h" Out of order include. ...
3 years, 7 months ago (2017-05-23 18:48:20 UTC) #4
rjkroege
https://codereview.chromium.org/2894523007/diff/1/ui/ozone/platform/drm/common/drm_util_unittest.cc File ui/ozone/platform/drm/common/drm_util_unittest.cc (right): https://codereview.chromium.org/2894523007/diff/1/ui/ozone/platform/drm/common/drm_util_unittest.cc#newcode5 ui/ozone/platform/drm/common/drm_util_unittest.cc:5: #include "ui/ozone/platform/drm/common/drm_util.h" On 2017/05/23 18:48:20, dnicoara wrote: > Out ...
3 years, 7 months ago (2017-05-23 22:08:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894523007/20001
3 years, 7 months ago (2017-05-23 22:09:32 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 02:50:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/54fee5d86ef41e706cb794d1c587...

Powered by Google App Engine
This is Rietveld 408576698