Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 2894493002: Allow building with VS 2017 Update 3 (Closed)

Created:
3 years, 7 months ago by brucedawson
Modified:
3 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow building with VS 2017 Update 3 VS 2017 Update 3 (preview available now) changes _MSC_VER from 1910 to 1911. This change detects this range as being VS 2017 in order to allow building and testing with the Update 3 preview. R=bauerb@chromium.org BUG=683729 Review-Url: https://codereview.chromium.org/2894493002 Cr-Commit-Position: refs/heads/master@{#472900} Committed: https://chromium.googlesource.com/chromium/src/+/f073ac02784b6a426a86e20c4623c09ae2a211ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/webui/version_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
brucedawson
Trivial change to allow building with the next update to VS 2017. PTAL.
3 years, 7 months ago (2017-05-18 18:08:30 UTC) #7
Bernhard Bauer
lgtm
3 years, 7 months ago (2017-05-18 18:22:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894493002/1
3 years, 7 months ago (2017-05-18 19:21:07 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 19:26:59 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f073ac02784b6a426a86e20c4623...

Powered by Google App Engine
This is Rietveld 408576698