chrome/browser/ui/webui/version_ui.cc - Issue 2894493002: Allow building with VS 2017 Update 3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/version_ui.cc

Issue 2894493002: Allow building with VS 2017 Update 3 (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/version_ui.cc

diff --git a/chrome/browser/ui/webui/version_ui.cc b/chrome/browser/ui/webui/version_ui.cc

index 0d918144a1995f3ef7763d7c91454e2188f7f283..632d0ea50c10ba050b491836798746bb621935ca 100644

--- a/chrome/browser/ui/webui/version_ui.cc

+++ b/chrome/browser/ui/webui/version_ui.cc

@@ -146,7 +146,7 @@ WebUIDataSource* CreateVersionUIDataSource() {

#else

html_source->AddString(version_ui::kCompiler, "MSVC 2015");

#endif

-#elif defined(_MSC_VER) && _MSC_VER == 1910

+#elif defined(_MSC_VER) && _MSC_VER >= 1910 && _MSC_VER <= 1911

#if BUILDFLAG(PGO_BUILD)

html_source->AddString(version_ui::kCompiler, "MSVC 2017 (PGO)");

#else

« no previous file with comments | « no previous file | no next file » | no next file with comments »