Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Side by Side Diff: chrome/browser/ui/webui/version_ui.cc

Issue 2894493002: Allow building with VS 2017 Update 3 (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/version_ui.h" 5 #include "chrome/browser/ui/webui/version_ui.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/i18n/message_formatter.h" 8 #include "base/i18n/message_formatter.h"
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 139
140 #if defined(OS_WIN) 140 #if defined(OS_WIN)
141 #if defined(__clang__) 141 #if defined(__clang__)
142 html_source->AddString(version_ui::kCompiler, "clang"); 142 html_source->AddString(version_ui::kCompiler, "clang");
143 #elif defined(_MSC_VER) && _MSC_VER == 1900 143 #elif defined(_MSC_VER) && _MSC_VER == 1900
144 #if BUILDFLAG(PGO_BUILD) 144 #if BUILDFLAG(PGO_BUILD)
145 html_source->AddString(version_ui::kCompiler, "MSVC 2015 (PGO)"); 145 html_source->AddString(version_ui::kCompiler, "MSVC 2015 (PGO)");
146 #else 146 #else
147 html_source->AddString(version_ui::kCompiler, "MSVC 2015"); 147 html_source->AddString(version_ui::kCompiler, "MSVC 2015");
148 #endif 148 #endif
149 #elif defined(_MSC_VER) && _MSC_VER == 1910 149 #elif defined(_MSC_VER) && _MSC_VER >= 1910 && _MSC_VER <= 1911
150 #if BUILDFLAG(PGO_BUILD) 150 #if BUILDFLAG(PGO_BUILD)
151 html_source->AddString(version_ui::kCompiler, "MSVC 2017 (PGO)"); 151 html_source->AddString(version_ui::kCompiler, "MSVC 2017 (PGO)");
152 #else 152 #else
153 html_source->AddString(version_ui::kCompiler, "MSVC 2017"); 153 html_source->AddString(version_ui::kCompiler, "MSVC 2017");
154 #endif 154 #endif
155 #elif defined(_MSC_VER) 155 #elif defined(_MSC_VER)
156 #error "Unsupported version of MSVC." 156 #error "Unsupported version of MSVC."
157 #else 157 #else
158 html_source->AddString(version_ui::kCompiler, "Unknown"); 158 html_source->AddString(version_ui::kCompiler, "Unknown");
159 #endif 159 #endif
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 // Set up the chrome://theme/ source. 191 // Set up the chrome://theme/ source.
192 ThemeSource* theme = new ThemeSource(profile); 192 ThemeSource* theme = new ThemeSource(profile);
193 content::URLDataSource::Add(profile, theme); 193 content::URLDataSource::Add(profile, theme);
194 #endif 194 #endif
195 195
196 WebUIDataSource::Add(profile, CreateVersionUIDataSource()); 196 WebUIDataSource::Add(profile, CreateVersionUIDataSource());
197 } 197 }
198 198
199 VersionUI::~VersionUI() { 199 VersionUI::~VersionUI() {
200 } 200 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698