Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2894233002: [animation-worklet] invoke animate callback on mutation signal (Closed)

Created:
3 years, 7 months ago by majidvp
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, kinuko+worker_chromium.org, shans, rjwright, blink-reviews-animation_chromium.org, sof, eae+blinkwatch, shimazu+worker_chromium.org, haraken, blink-reviews-dom_chromium.org, dglazkov+blink, hongchan, Raymond Toy, darktears, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, rwlbuis, kinuko+watch, blink-worker-reviews_chromium.org, Eric Willigers
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Call |animate| function in worklet scope anytime worklet received a mutation signal. BUG=666001

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+507 lines, -24 lines) Patch
A third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/animation-worklet-animator-registration.html View 1 chunk +72 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/animation-worklet-animator-registration-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/AnimationWorkletProxyClient.h View 1 chunk +17 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/core/dom/AnimationWorkletProxyClient.cpp View 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.h View 3 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp View 3 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorkletGlobalScope.h View 3 chunks +28 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorkletGlobalScope.cpp View 3 chunks +120 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorkletGlobalScope.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorkletMessagingProxy.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorkletMessagingProxy.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThread.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/modules/compositorworker/Animator.h View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/compositorworker/Animator.cpp View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/compositorworker/AnimatorDefinition.h View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/compositorworker/AnimatorDefinition.cpp View 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioWorkletMessagingProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/AnimationWorkletProxyClientImpl.h View 3 chunks +12 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/AnimationWorkletProxyClientImpl.cpp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (5 generated)
majidvp
The CQ bit was checked by majidvp@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-23 13:34:54 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894233002/1
3 years, 7 months ago (2017-05-23 13:35:10 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-23 15:08:23 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/462116)
3 years, 7 months ago (2017-05-23 15:08:24 UTC) #4
majidvp
3 years, 7 months ago (2017-05-24 14:23:42 UTC) #5 
Description was changed from

==========
WIP - animate-callback

BUG=
==========

to

==========
Call |animate| function in worklet scope anytime worklet
received a mutation signal.


BUG=666001
==========

Powered by Google App Engine
This is Rietveld 408576698