Refactor UKM interface for mojo-ification

Refactor UKM interface for mojo-ification

(landing for holte@ who is OOO; original CL is https://codereview.chromium.org/2883563002/ and all lgtms are there)

* ukm::UkmEntry replaced by ukm::mojom::UkmEntry
 - Several tests updated to look at these entries instead of protos
* Created an interface class and updated recording code to use it:
  UkmService -> UkmRecorder.
* Moved code need for implementing that interface from
  UkmService -> UkmRecorderImpl.
* Replaced TestUkmService with TestUkmRecorder, and removed the harness
  code which became unnecessary.
* Moved UkmEntryBuilder to components/ukm/public/

TBR=sebsg,yzshen1,sky,groby,holte

Review-Url: https://codereview.chromium.org/2893943004
Cr-Commit-Position: refs/heads/master@{#473757}
Committed: https://chromium.googlesource.com/chromium/src/+/b068f2742e5145f6225a7945771df199f051eec9

[oystein (OOO til 10th of July), 2017-05-18 22:07:02]

Description was changed from

==========
Refactor UKM interface for mojo-ification

(landing for holte@ who is OOO; original CL is
https://codereview.chromium.org/2885363004/)

* ukm::UkmEntry replaced by ukm::mojom::UkmEntry
 - Several tests updated to look at these entries instead of protos
* Created an interface class and updated recording code to use it:
  UkmService -> UkmRecorder.
* Moved code need for implementing that interface from
  UkmService -> UkmRecorderImpl.
* Replaced TestUkmService with TestUkmRecorder, and removed the harness
  code which became unnecessary.
* Moved UkmEntryBuilder to components/ukm/public/

TBR=sebsg,yzshen1,sky,groby
==========

to

==========
Refactor UKM interface for mojo-ification

(landing for holte@ who is OOO; original CL is
https://codereview.chromium.org/2885363004/)

* ukm::UkmEntry replaced by ukm::mojom::UkmEntry
 - Several tests updated to look at these entries instead of protos
* Created an interface class and updated recording code to use it:
  UkmService -> UkmRecorder.
* Moved code need for implementing that interface from
  UkmService -> UkmRecorderImpl.
* Replaced TestUkmService with TestUkmRecorder, and removed the harness
  code which became unnecessary.
* Moved UkmEntryBuilder to components/ukm/public/

TBR=sebsg,yzshen1,sky,groby,holte
==========

[oystein (OOO til 10th of July), 2017-05-18 22:07:02]

oysteine@chromium.org changed reviewers:
+ holte@chromium.org

[oystein (OOO til 10th of July), 2017-05-18 23:12:27]

The CQ bit was checked by oysteine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 23:13:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 23:45:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 23:45:27]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[oystein (OOO til 10th of July), 2017-05-22 18:18:24]

Description was changed from

==========
Refactor UKM interface for mojo-ification

(landing for holte@ who is OOO; original CL is
https://codereview.chromium.org/2885363004/)

* ukm::UkmEntry replaced by ukm::mojom::UkmEntry
 - Several tests updated to look at these entries instead of protos
* Created an interface class and updated recording code to use it:
  UkmService -> UkmRecorder.
* Moved code need for implementing that interface from
  UkmService -> UkmRecorderImpl.
* Replaced TestUkmService with TestUkmRecorder, and removed the harness
  code which became unnecessary.
* Moved UkmEntryBuilder to components/ukm/public/

TBR=sebsg,yzshen1,sky,groby,holte
==========

to

==========
Refactor UKM interface for mojo-ification

(landing for holte@ who is OOO; original CL is
https://codereview.chromium.org/2885363004/ and all lgtms are there)

* ukm::UkmEntry replaced by ukm::mojom::UkmEntry
 - Several tests updated to look at these entries instead of protos
* Created an interface class and updated recording code to use it:
  UkmService -> UkmRecorder.
* Moved code need for implementing that interface from
  UkmService -> UkmRecorderImpl.
* Replaced TestUkmService with TestUkmRecorder, and removed the harness
  code which became unnecessary.
* Moved UkmEntryBuilder to components/ukm/public/

TBR=sebsg,yzshen1,sky,groby,holte
==========

[oystein (OOO til 10th of July), 2017-05-22 19:17:11]

The CQ bit was checked by oysteine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 19:17:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 19:49:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 19:49:12]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[oystein (OOO til 10th of July), 2017-05-22 21:24:33]

oysteine@chromium.org changed reviewers:
+ donnd@chromium.org

[oystein (OOO til 10th of July), 2017-05-22 21:24:56]

+donnd for chrome/browser/android/contextualsearch

[oystein (OOO til 10th of July), 2017-05-22 21:25:12]

The CQ bit was checked by oysteine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 21:25:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oystein (OOO til 10th of July), 2017-05-22 21:26:04]

(Everyone else: please ignore as this is the clone of
https://codereview.chromium.org/2885363004/)

[oystein (OOO til 10th of July), 2017-05-22 21:44:53]

Description was changed from

==========
Refactor UKM interface for mojo-ification

(landing for holte@ who is OOO; original CL is
https://codereview.chromium.org/2885363004/ and all lgtms are there)

* ukm::UkmEntry replaced by ukm::mojom::UkmEntry
 - Several tests updated to look at these entries instead of protos
* Created an interface class and updated recording code to use it:
  UkmService -> UkmRecorder.
* Moved code need for implementing that interface from
  UkmService -> UkmRecorderImpl.
* Replaced TestUkmService with TestUkmRecorder, and removed the harness
  code which became unnecessary.
* Moved UkmEntryBuilder to components/ukm/public/

TBR=sebsg,yzshen1,sky,groby,holte
==========

to

==========
Refactor UKM interface for mojo-ification

(landing for holte@ who is OOO; original CL is
https://codereview.chromium.org/2883563002/ and all lgtms are there)

* ukm::UkmEntry replaced by ukm::mojom::UkmEntry
 - Several tests updated to look at these entries instead of protos
* Created an interface class and updated recording code to use it:
  UkmService -> UkmRecorder.
* Moved code need for implementing that interface from
  UkmService -> UkmRecorderImpl.
* Replaced TestUkmService with TestUkmRecorder, and removed the harness
  code which became unnecessary.
* Moved UkmEntryBuilder to components/ukm/public/

TBR=sebsg,yzshen1,sky,groby,holte
==========

[Donn Denman, 2017-05-22 22:30:01]

LGTM for ContextualSearch.

[Donn Denman, 2017-05-22 22:37:44]

BTW, You should change the description to refer to the original CL
https://chromiumcodereview.appspot.com/2883563002/ (not
https://codereview.chromium.org/2885363004/)

[oystein (OOO til 10th of July), 2017-05-22 22:45:58]

On 2017/05/22 at 22:37:44, donnd wrote:
> BTW, You should change the description to refer to the original CL
https://chromiumcodereview.appspot.com/2883563002/ (not
https://codereview.chromium.org/2885363004/)

Yep sorry, I caught that right after sending this one out :/.

[commit-bot: I haz the power, 2017-05-22 23:58:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 23:58:07]

Dry run: This issue passed the CQ dry run.

[oystein (OOO til 10th of July), 2017-05-23 00:05:31]

The CQ bit was checked by oysteine@chromium.org

[commit-bot: I haz the power, 2017-05-23 00:06:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 00:14:05]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495497931846730,
"parent_rev": "4808673d8daf77d882a14591d103a052c92a430f", "commit_rev":
"b068f2742e5145f6225a7945771df199f051eec9"}

[commit-bot: I haz the power, 2017-05-23 00:14:17]

Description was changed from

==========
Refactor UKM interface for mojo-ification

(landing for holte@ who is OOO; original CL is
https://codereview.chromium.org/2883563002/ and all lgtms are there)

* ukm::UkmEntry replaced by ukm::mojom::UkmEntry
 - Several tests updated to look at these entries instead of protos
* Created an interface class and updated recording code to use it:
  UkmService -> UkmRecorder.
* Moved code need for implementing that interface from
  UkmService -> UkmRecorderImpl.
* Replaced TestUkmService with TestUkmRecorder, and removed the harness
  code which became unnecessary.
* Moved UkmEntryBuilder to components/ukm/public/

TBR=sebsg,yzshen1,sky,groby,holte
==========

to

==========
Refactor UKM interface for mojo-ification

(landing for holte@ who is OOO; original CL is
https://codereview.chromium.org/2883563002/ and all lgtms are there)

* ukm::UkmEntry replaced by ukm::mojom::UkmEntry
 - Several tests updated to look at these entries instead of protos
* Created an interface class and updated recording code to use it:
  UkmService -> UkmRecorder.
* Moved code need for implementing that interface from
  UkmService -> UkmRecorderImpl.
* Replaced TestUkmService with TestUkmRecorder, and removed the harness
  code which became unnecessary.
* Moved UkmEntryBuilder to components/ukm/public/

TBR=sebsg,yzshen1,sky,groby,holte

Review-Url: https://codereview.chromium.org/2893943004
Cr-Commit-Position: refs/heads/master@{#473757}
Committed:
https://chromium.googlesource.com/chromium/src/+/b068f2742e5145f6225a7945771d...
==========

[commit-bot: I haz the power, 2017-05-23 00:14:20]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b068f2742e5145f6225a7945771d...