chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h - Issue 2893943004: Refactor UKM interface for mojo-ification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h

Issue 2893943004: Refactor UKM interface for mojo-ification (Closed)

Patch Set: Fixed contextualsearch Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h

index 2e24c0b3cca2cf5cfffee53f450fbd924f97ca67..5cbe5924ad6baac68d28e2722d5cc15db1f5fffe 100644

--- a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h

@@ -9,6 +9,7 @@

#include "base/optional.h"

#include "base/time/time.h"

#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"

+#include "components/ukm/ukm_service.h"

#include "net/nqe/network_quality_estimator.h"

#include "ui/base/page_transition_types.h"

@@ -88,7 +89,7 @@ class UkmPageLoadMetricsObserver

network_quality_provider_;

// Unique UKM identifier for the page load we are recording metrics for.

- const int32_t source_id_;

+ const ukm::SourceId source_id_;

// Network quality estimates.

net::EffectiveConnectionType effective_connection_type_ =