Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.cc

Issue 2893943004: Refactor UKM interface for mojo-ification (Closed)
Patch Set: Fixed contextualsearch Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <chrome/browser/android/contextualsearch/contextual_search_ranker_logge r_impl.h> 5 #include <chrome/browser/android/contextualsearch/contextual_search_ranker_logge r_impl.h>
6 6
7 #include "base/android/jni_string.h" 7 #include "base/android/jni_string.h"
8 #include "base/android/scoped_java_ref.h" 8 #include "base/android/scoped_java_ref.h"
9 #include "base/metrics/metrics_hashes.h" 9 #include "base/metrics/metrics_hashes.h"
10 #include "chrome/browser/browser_process.h" 10 #include "chrome/browser/browser_process.h"
11 #include "components/keyed_service/core/keyed_service.h" 11 #include "components/keyed_service/core/keyed_service.h"
12 #include "components/ukm/ukm_entry_builder.h" 12 #include "components/ukm/public/ukm_entry_builder.h"
13 #include "components/ukm/ukm_service.h" 13 #include "components/ukm/public/ukm_recorder.h"
14 #include "jni/ContextualSearchRankerLoggerImpl_jni.h" 14 #include "jni/ContextualSearchRankerLoggerImpl_jni.h"
15 15
16 ContextualSearchRankerLoggerImpl::ContextualSearchRankerLoggerImpl( 16 ContextualSearchRankerLoggerImpl::ContextualSearchRankerLoggerImpl(
17 JNIEnv* env, 17 JNIEnv* env,
18 jobject obj) { 18 jobject obj) {
19 java_object_.Reset(env, obj); 19 java_object_.Reset(env, obj);
20 } 20 }
21 21
22 ContextualSearchRankerLoggerImpl::~ContextualSearchRankerLoggerImpl() { 22 ContextualSearchRankerLoggerImpl::~ContextualSearchRankerLoggerImpl() {
23 java_object_ = nullptr; 23 java_object_ = nullptr;
24 } 24 }
25 25
26 void ContextualSearchRankerLoggerImpl::SetupLoggingAndRanker( 26 void ContextualSearchRankerLoggerImpl::SetupLoggingAndRanker(
27 JNIEnv* env, 27 JNIEnv* env,
28 jobject obj, 28 jobject obj,
29 const base::android::JavaParamRef<jstring>& j_base_page_url) { 29 const base::android::JavaParamRef<jstring>& j_base_page_url) {
30 GURL page_url = 30 GURL page_url =
31 GURL(base::android::ConvertJavaStringToUTF8(env, j_base_page_url)); 31 GURL(base::android::ConvertJavaStringToUTF8(env, j_base_page_url));
32 ukm::UkmService* ukm_service = g_browser_process->ukm_service(); 32 ukm::UkmRecorder* ukm_recorder = g_browser_process->ukm_recorder();
33 SetUkmService(ukm_service, page_url); 33 SetUkmRecorder(ukm_recorder, page_url);
34 // TODO(donnd): set up the model once inference is available. 34 // TODO(donnd): set up the model once inference is available.
35 } 35 }
36 36
37 void ContextualSearchRankerLoggerImpl::SetUkmService( 37 void ContextualSearchRankerLoggerImpl::SetUkmRecorder(
38 ukm::UkmService* ukm_service, 38 ukm::UkmRecorder* ukm_recorder,
39 const GURL& page_url) { 39 const GURL& page_url) {
40 ukm_service_ = ukm_service; 40 ukm_recorder_ = ukm_recorder;
41 source_id_ = ukm_service_->GetNewSourceID(); 41 source_id_ = ukm_recorder_->GetNewSourceID();
42 ukm_service_->UpdateSourceURL(source_id_, page_url); 42 ukm_recorder_->UpdateSourceURL(source_id_, page_url);
43 builder_ = ukm_service_->GetEntryBuilder(source_id_, "ContextualSearch"); 43 builder_ = ukm_recorder_->GetEntryBuilder(source_id_, "ContextualSearch");
44 } 44 }
45 45
46 void ContextualSearchRankerLoggerImpl::LogLong( 46 void ContextualSearchRankerLoggerImpl::LogLong(
47 JNIEnv* env, 47 JNIEnv* env,
48 jobject obj, 48 jobject obj,
49 const base::android::JavaParamRef<jstring>& j_feature, 49 const base::android::JavaParamRef<jstring>& j_feature,
50 jlong j_long) { 50 jlong j_long) {
51 std::string feature = base::android::ConvertJavaStringToUTF8(env, j_feature); 51 std::string feature = base::android::ConvertJavaStringToUTF8(env, j_feature);
52 builder_->AddMetric(feature.c_str(), j_long); 52 builder_->AddMetric(feature.c_str(), j_long);
53 } 53 }
54 54
55 void ContextualSearchRankerLoggerImpl::WriteLogAndReset(JNIEnv* env, 55 void ContextualSearchRankerLoggerImpl::WriteLogAndReset(JNIEnv* env,
56 jobject obj) { 56 jobject obj) {
57 // Set up another builder for the next record (in case it's needed). 57 // Set up another builder for the next record (in case it's needed).
58 builder_ = ukm_service_->GetEntryBuilder(source_id_, "ContextualSearch"); 58 builder_ = ukm_recorder_->GetEntryBuilder(source_id_, "ContextualSearch");
59 } 59 }
60 60
61 // Java wrapper boilerplate 61 // Java wrapper boilerplate
62 62
63 void ContextualSearchRankerLoggerImpl::Destroy( 63 void ContextualSearchRankerLoggerImpl::Destroy(
64 JNIEnv* env, 64 JNIEnv* env,
65 const base::android::JavaParamRef<jobject>& obj) { 65 const base::android::JavaParamRef<jobject>& obj) {
66 delete this; 66 delete this;
67 } 67 }
68 68
69 bool RegisterContextualSearchRankerLoggerImpl(JNIEnv* env) { 69 bool RegisterContextualSearchRankerLoggerImpl(JNIEnv* env) {
70 return RegisterNativesImpl(env); 70 return RegisterNativesImpl(env);
71 } 71 }
72 72
73 jlong Init(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj) { 73 jlong Init(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj) {
74 ContextualSearchRankerLoggerImpl* ranker_logger_impl = 74 ContextualSearchRankerLoggerImpl* ranker_logger_impl =
75 new ContextualSearchRankerLoggerImpl(env, obj); 75 new ContextualSearchRankerLoggerImpl(env, obj);
76 return reinterpret_cast<intptr_t>(ranker_logger_impl); 76 return reinterpret_cast<intptr_t>(ranker_logger_impl);
77 } 77 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698