Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl

Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl b/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl
index 15e18ecca676dd712840250d0300de970396c624..0b9cffe9e4c158fabb82ce8679e54a0cf161cace 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl
@@ -18,8 +18,6 @@
readonly attribute sequence<PaymentDetailsModifier> modifiers;
readonly attribute DOMString instrumentKey;
- // TODO(gogerald): We should implement this function.
- // Please see: http://crbug.com/720027
- // Promise<WindowClient> openWindow(USVString url);
+ [CallWith=ScriptState] Promise<WindowClient?> openWindow(USVString url);
zino 2017/05/25 17:02:42 This should be Promise<WindowClient> according to
please use gerrit instead 2017/05/25 17:56:13 What zino said.
gogerald1 2017/05/29 22:13:16 Done.
[CallWith=ScriptState, RaisesException] void respondWith(Promise<PaymentResponse> response);
};

Powered by Google App Engine
This is Rietveld 408576698