Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl

Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler (Closed)
Patch Set: address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // https://w3c.github.io/payment-handler/#the-paymentrequestevent 5 // https://w3c.github.io/payment-handler/#the-paymentrequestevent
6 6
7 // TODO(zino): Once the spec issue is resolved, we should apply the changes. 7 // TODO(zino): Once the spec issue is resolved, we should apply the changes.
8 // Please see https://github.com/w3c/payment-handler/pull/162 8 // Please see https://github.com/w3c/payment-handler/pull/162
9 [ 9 [
10 RuntimeEnabled=PaymentApp, 10 RuntimeEnabled=PaymentApp,
11 Exposed=ServiceWorker 11 Exposed=ServiceWorker
12 ] interface PaymentRequestEvent : ExtendableEvent { 12 ] interface PaymentRequestEvent : ExtendableEvent {
13 readonly attribute DOMString topLevelOrigin; 13 readonly attribute DOMString topLevelOrigin;
14 readonly attribute DOMString paymentRequestOrigin; 14 readonly attribute DOMString paymentRequestOrigin;
15 readonly attribute DOMString paymentRequestId; 15 readonly attribute DOMString paymentRequestId;
16 readonly attribute sequence<PaymentMethodData> methodData; 16 readonly attribute sequence<PaymentMethodData> methodData;
17 readonly attribute PaymentItem total; 17 readonly attribute PaymentItem total;
18 readonly attribute sequence<PaymentDetailsModifier> modifiers; 18 readonly attribute sequence<PaymentDetailsModifier> modifiers;
19 readonly attribute DOMString instrumentKey; 19 readonly attribute DOMString instrumentKey;
20 20
21 // TODO(gogerald): We should implement this function. 21 [CallWith=ScriptState] Promise<WindowClient?> openWindow(USVString url);
zino 2017/05/25 17:02:42 This should be Promise<WindowClient> according to
please use gerrit instead 2017/05/25 17:56:13 What zino said.
gogerald1 2017/05/29 22:13:16 Done.
22 // Please see: http://crbug.com/720027
23 // Promise<WindowClient> openWindow(USVString url);
24 [CallWith=ScriptState, RaisesException] void respondWith(Promise<PaymentResp onse> response); 22 [CallWith=ScriptState, RaisesException] void respondWith(Promise<PaymentResp onse> response);
25 }; 23 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698