third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.h - Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.h

Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler (Closed)

Patch Set: address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl ('K') | « third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp » ('j') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.h

index 5cd7c05bc18ba7d725aa733c2c876b9472055086..35d46c663d9f429258529785fdd1ce7bb1b48030 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.h

@@ -29,6 +29,12 @@ class ServiceWorkerClients final

ScriptPromise openWindow(ScriptState*, const String& url);

ScriptPromise claim(ScriptState*);

+ // This interface is not part of Clients.idl. |redirect_url| is the last

+ // navigation occured before |url|.

+ ScriptPromise openWindow(ScriptState*,

+ const String& redirect_url,

+ const String& url);

DEFINE_INLINE_TRACE() {}

private: