Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

Issue 2893823004: [Payments] Implement openWindow for service worker based payment handler (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
index 43c4452e105d4e2eceee39aeaea7fd41a7f49055..9651c6afc0ef425f5ad9e18b3fa24a8d57dce306 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
@@ -69,7 +69,8 @@ class MODULES_EXPORT ServiceWorkerGlobalScopeClient
virtual void GetClients(
const WebServiceWorkerClientQueryOptions&,
std::unique_ptr<WebServiceWorkerClientsCallbacks>) = 0;
- virtual void OpenWindow(const WebURL&,
+ virtual void OpenWindow(const WebURL& redirect_url,
zino 2017/05/25 17:02:42 It might be better to add a new method (e.g. OpenW
please use gerrit instead 2017/05/25 17:56:13 +1
gogerald1 2017/05/29 22:13:16 Done.
+ const WebURL&,
std::unique_ptr<WebServiceWorkerClientCallbacks>) = 0;
virtual void SetCachedMetadata(const WebURL&, const char*, size_t) = 0;
virtual void ClearCachedMetadata(const WebURL&) = 0;

Powered by Google App Engine
This is Rietveld 408576698