Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2893073003: ozone: evdev: Use correct integer width for gamepad axis values (Closed)

Created:
3 years, 7 months ago by jkwang
Modified:
3 years, 7 months ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Use correct integer width for gamepad axis values Gamepad event value should be int instead of uint16_t. This patch fixes the bug. BUG=717246 TEST=Add/Fix and run unittest. Review-Url: https://codereview.chromium.org/2893073003 Cr-Commit-Position: refs/heads/master@{#475110} Committed: https://chromium.googlesource.com/chromium/src/+/1635d1c9793a83ecbe0c8333c7f0c4beb115034e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ui/events/ozone/evdev/gamepad_event_converter_evdev.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/events/ozone/evdev/gamepad_event_converter_evdev.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jkwang
3 years, 7 months ago (2017-05-23 22:10:06 UTC) #3
spang
lgtm
3 years, 7 months ago (2017-05-25 23:01:52 UTC) #4
spang
On 2017/05/25 23:01:52, spang wrote: > lgtm
3 years, 7 months ago (2017-05-25 23:03:39 UTC) #6
spang
(In the future please use a more descriptive title)
3 years, 7 months ago (2017-05-25 23:04:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893073003/1
3 years, 7 months ago (2017-05-26 19:51:05 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 20:35:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1635d1c9793a83ecbe0c8333c7f0...

Powered by Google App Engine
This is Rietveld 408576698