Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(54)

Issue 2892843003: [subresource_filter] Reland: Decide UNSUPPORTED_SCHEME only if we'd otherwise activate (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by Charlie Harrison
Modified:
4 months, 1 week ago
Reviewers:
Bryan McQuade
CC:
chromium-reviews, darin-cc_chromium.org, jam, subresource-filter-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[subresource_filter] Reland: Decide UNSUPPORTED_SCHEME only if we'd activate This previously landed in [1] but was reverted because it depended on a CL which had undefined behavior. This is a reland with nothing changed [1] https://codereview.chromium.org/2888163002/ TBR=bmcquade@chromium.org Review-Url: https://codereview.chromium.org/2892843003 Cr-Commit-Position: refs/heads/master@{#473246} Committed: https://chromium.googlesource.com/chromium/src/+/b08a2520149a3f6e7f6c5fc31d0ea10d32af92da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -11 lines) Patch
M chrome/browser/subresource_filter/subresource_filter_unittest.cc View 2 chunks +40 lines, -0 lines 0 comments Download
M components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc View 3 chunks +29 lines, -9 lines 0 comments Download
M components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc View 1 chunk +10 lines, -2 lines 0 comments Download
Commit queue not available (can’t edit this change).

Depends on Patchset:

Messages

Total messages: 14 (8 generated)
Charlie Harrison
bmcquade: TBR on this reland which I'll land when the dependent one relands.
4 months, 1 week ago (2017-05-19 12:59:31 UTC) #4
Bryan McQuade
lgtm
4 months, 1 week ago (2017-05-19 13:21:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892843003/1
4 months, 1 week ago (2017-05-19 15:21:15 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/449902)
4 months, 1 week ago (2017-05-19 16:23:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892843003/1
4 months, 1 week ago (2017-05-19 17:19:52 UTC) #11
commit-bot: I haz the power
4 months, 1 week ago (2017-05-19 18:06:02 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b08a2520149a3f6e7f6c5fc31d0e...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b