[subresource_filter] Reland: Decide UNSUPPORTED_SCHEME only if we'd otherwise activate

chrome/browser/subresource_filter/subresource_filter_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <utility>
 
 #include "base/feature_list.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
@@ skipping 15 matching lines @@
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/prefs/testing_pref_service.h"
 #include "components/safe_browsing_db/v4_protocol_manager_util.h"
 #include "components/subresource_filter/content/browser/content_ruleset_service.h"
 #include "components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h"
 #include "components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h"
 #include "components/subresource_filter/core/browser/ruleset_service.h"
 #include "components/subresource_filter/core/browser/subresource_filter_features.h"
 #include "components/subresource_filter/core/browser/subresource_filter_features_test_support.h"
+#include "components/subresource_filter/core/common/activation_decision.h"
 #include "components/subresource_filter/core/common/test_ruleset_creator.h"
 #include "content/public/browser/navigation_throttle.h"
 #include "content/public/test/navigation_simulator.h"
 #include "content/public/test/test_renderer_host.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 namespace {
 using subresource_filter::testing::ScopedSubresourceFilterConfigurator;
 using subresource_filter::testing::ScopedSubresourceFilterFeatureToggle;
@@ skipping 203 matching lines @@
 
   // Simulate explicit whitelisting and reload.
   settings_manager()->WhitelistSite(url);
   SimulateNavigateAndCommit(url, main_rfh());
   EXPECT_TRUE(CreateAndNavigateDisallowedSubframe(main_rfh()));
 
   // Should not have cleared the metadata, since the site is still on the SB
   // blacklist.
   EXPECT_NE(nullptr, settings_manager()->GetSiteMetadata(url));
 }
+
+TEST_F(SubresourceFilterTest,
+       NavigationToBadSchemeUrlWithNoActivation_DoesNotReportBadScheme) {
+  // Don't report UNSUPPORTED_SCHEME if the navigation has no matching
+  // configuration.
+  scoped_configuration().ResetConfiguration(subresource_filter::Configuration(
+      subresource_filter::ActivationLevel::DISABLED,
+      subresource_filter::ActivationScope::NO_SITES));
+
+  GURL url("data:text/html,hello world");
+  SimulateNavigateAndCommit(url, main_rfh());
+  EXPECT_TRUE(CreateAndNavigateDisallowedSubframe(main_rfh()));
+  auto* driver_factory = subresource_filter::
+      ContentSubresourceFilterDriverFactory::FromWebContents(web_contents());
+  EXPECT_EQ(
+      subresource_filter::ActivationDecision::ACTIVATION_CONDITIONS_NOT_MET,
+      driver_factory->GetActivationDecisionForLastCommittedPageLoad());
+
+  // Also don't report UNSUPPORTED_SCHEME if the navigation matches a
+  // configuration with DISABLED activation level.
+  scoped_configuration().ResetConfiguration(subresource_filter::Configuration(
+      subresource_filter::ActivationLevel::DISABLED,
+      subresource_filter::ActivationScope::ALL_SITES));
+
+  SimulateNavigateAndCommit(url, main_rfh());
+  EXPECT_TRUE(CreateAndNavigateDisallowedSubframe(main_rfh()));
+  EXPECT_EQ(subresource_filter::ActivationDecision::ACTIVATION_DISABLED,
+            driver_factory->GetActivationDecisionForLastCommittedPageLoad());
+
+  // Sanity check that UNSUPPORTED_SCHEME is reported if the navigation does
+  // activate.
+  scoped_configuration().ResetConfiguration(subresource_filter::Configuration(
+      subresource_filter::ActivationLevel::ENABLED,
+      subresource_filter::ActivationScope::ALL_SITES));
+  SimulateNavigateAndCommit(url, main_rfh());
+  EXPECT_TRUE(CreateAndNavigateDisallowedSubframe(main_rfh()));
+  EXPECT_EQ(subresource_filter::ActivationDecision::UNSUPPORTED_SCHEME,
+            driver_factory->GetActivationDecisionForLastCommittedPageLoad());
+}