Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h

Issue 2892843003: [subresource_filter] Reland: Decide UNSUPPORTED_SCHEME only if we'd otherwise activate (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h
diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h
index 427f8dd4cb94fac88e23626cce5c860fb926f5b8..6718e6dbbf603774e82fed75cdde4c5b5590a752 100644
--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h
+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h
@@ -101,8 +101,10 @@ class ContentSubresourceFilterDriverFactory
// Returns whether a main-frame navigation to the given |url| satisfies the
// activation |conditions| of a given configuration, except for |priority|.
+ // Pass |scheme_is_http_or_https| to avoid multiple string comparisons.
bool DoesMainFrameURLSatisfyActivationConditions(
const GURL& url,
+ bool scheme_is_http_or_https,
const Configuration::ActivationConditions& conditions,
ActivationList matched_list) const;

Powered by Google App Engine
This is Rietveld 408576698