components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h - Issue 2892843003: [subresource_filter] Reland: Decide UNSUPPORTED_SCHEME only if we'd otherwise activate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h

Issue 2892843003: [subresource_filter] Reland: Decide UNSUPPORTED_SCHEME only if we'd otherwise activate (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/subresource_filter/subresource_filter_unittest.cc ('k') | components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h

diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h

index 427f8dd4cb94fac88e23626cce5c860fb926f5b8..6718e6dbbf603774e82fed75cdde4c5b5590a752 100644

--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h

+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h

@@ -101,8 +101,10 @@ class ContentSubresourceFilterDriverFactory

// Returns whether a main-frame navigation to the given |url| satisfies the

// activation |conditions| of a given configuration, except for |priority|.

+ // Pass |scheme_is_http_or_https| to avoid multiple string comparisons.

bool DoesMainFrameURLSatisfyActivationConditions(

const GURL& url,

+ bool scheme_is_http_or_https,

const Configuration::ActivationConditions& conditions,

ActivationList matched_list) const;