Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2892803002: Fix layout tests to prevent errors from layout-test-tidy (Closed)

Created:
3 years, 7 months ago by hongchan
Modified:
3 years, 7 months ago
Reviewers:
Raymond Toy
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix layout tests to prevent errors from layout-test-tidy Some layout tests were failing after application of layout-test-tidy because of duplicate variables and missing semicolon. Fix them before tidying the code. BUG=723859 Review-Url: https://codereview.chromium.org/2892803002 Cr-Commit-Position: refs/heads/master@{#473240} Committed: https://chromium.googlesource.com/chromium/src/+/cc41c678cbc49da1c37df906a14d22c938c06e38

Patch Set 1 #

Total comments: 15
Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -189 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix.html View 4 chunks +17 lines, -19 lines 2 comments Download
M third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-freq-data.html View 6 chunks +31 lines, -32 lines 3 comments Download
M third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-freq-data-smoothing.html View 3 chunks +23 lines, -25 lines 2 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-ended.html View 1 chunk +1 line, -1 line 2 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-zero.html View 2 chunks +13 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html View 8 chunks +34 lines, -33 lines 2 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-getFrequencyResponse.html View 10 chunks +48 lines, -57 lines 2 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-ended.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/internals/scriptprocessornode-premature-death.html View 4 chunks +8 lines, -8 lines 2 comments Download

Messages

Total messages: 11 (5 generated)
hongchan
PTAL.
3 years, 7 months ago (2017-05-18 18:05:14 UTC) #3
Raymond Toy
https://codereview.chromium.org/2892803002/diff/1/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix.html File third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix.html (left): https://codereview.chromium.org/2892803002/diff/1/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix.html#oldcode105 third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix.html:105: var success = compareFloatFreq(prefix + " freq data", freqData, ...
3 years, 7 months ago (2017-05-19 13:53:38 UTC) #4
hongchan
https://codereview.chromium.org/2892803002/diff/1/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix.html File third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix.html (left): https://codereview.chromium.org/2892803002/diff/1/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix.html#oldcode105 third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix.html:105: var success = compareFloatFreq(prefix + " freq data", freqData, ...
3 years, 7 months ago (2017-05-19 16:15:29 UTC) #5
Raymond Toy
lgtm
3 years, 7 months ago (2017-05-19 16:29:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892803002/1
3 years, 7 months ago (2017-05-19 16:38:08 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 17:55:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cc41c678cbc49da1c37df906a14d...

Powered by Google App Engine
This is Rietveld 408576698