Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html

Issue 2892803002: Fix layout tests to prevent errors from layout-test-tidy (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html b/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html
index e9c8b10565e819d2b8e3bdda8831e36eaa2b9f81..ff188116bc7d4945fc3174a5c3b922bf857cc4b0 100644
--- a/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html
+++ b/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html
@@ -11,25 +11,25 @@
<body>
<script>
- var sampleRate = 48000;
+ let sampleRate = 48000;
// Some short duration because we don't need to run the test for very long.
- var testDurationSec = 0.125;
- var testDurationFrames = testDurationSec * sampleRate;
+ let testDurationSec = 0.125;
+ let testDurationFrames = testDurationSec * sampleRate;
- var audit = Audit.createTaskRunner();
+ let audit = Audit.createTaskRunner();
audit.define("setValueCurve", (task, should) => {
- var success = true;
- var context = new OfflineAudioContext(1, testDurationFrames, sampleRate);
- var g = context.createGain();
- var curve = new Float32Array(2);
+ let success = true;
+ let context = new OfflineAudioContext(1, testDurationFrames, sampleRate);
+ let g = context.createGain();
+ let curve = new Float32Array(2);
// Start time and duration for setValueCurveAtTime
- var curveStartTime = 0.1 * testDurationSec;
- var duration = 0.1 * testDurationSec;
+ let curveStartTime = 0.1 * testDurationSec;
+ let duration = 0.1 * testDurationSec;
// Some time that is known to during the setValueCurveTime interval.
- var automationTime = curveStartTime + duration / 2;
+ let automationTime = curveStartTime + duration / 2;
should(() => {
g.gain.setValueCurveAtTime(curve, curveStartTime, duration);
@@ -67,13 +67,14 @@
});
audit.define("automations", (task, should) => {
- var context = new OfflineAudioContext(1, testDurationFrames, sampleRate);
- var g = context.createGain();
+ let context = new OfflineAudioContext(1, testDurationFrames, sampleRate);
+ let g = context.createGain();
- var curve = new Float32Array(2);
+ let curve = new Float32Array(2);
// Start time and duration for setValueCurveAtTime
- var startTime = 0;
- var timeInterval = testDurationSec / 10;
+ let startTime = 0;
+ let timeInterval = testDurationSec / 10;
+ let time;
Raymond Toy 2017/05/19 13:53:38 This declaration of time is the actual fix, right?
hongchan 2017/05/19 16:15:29 See line 192. You actually create a |time| variabl
startTime += timeInterval;
should(() => {
@@ -98,8 +99,8 @@
// Now try to setValueCurve that overlaps each of the above automations
startTime = timeInterval / 2;
- for (var k = 0; k < 4; ++k) {
- var time = startTime + timeInterval * k;
+ for (let k = 0; k < 4; ++k) {
+ time = startTime + timeInterval * k;
should(() => {
g.gain.setValueCurveAtTime(curve, time, 0.01);
},
@@ -122,7 +123,7 @@
"setValueCurveAtTime([1, Infinity], " + time + ", 0.01)")
.throw("TypeError");
- var d = context.createDelay();
+ let d = context.createDelay();
// Check that we get warnings for out-of-range values and also throw for
// non-finite values.
should(() => {
@@ -141,7 +142,7 @@
.throw("TypeError");
// One last test that prints out lots of digits for the time.
- var time = Math.PI / 100;
+ time = Math.PI / 100;
should(() => {
g.gain.setValueCurveAtTime(curve, time, 0.01);
}, "setValueCurveAtTime(curve, " + time + ", 0.01)").throw("NotSupportedError");
@@ -151,11 +152,11 @@
audit.define("catch-exception", (task, should) => {
// Verify that the curve isn't inserted into the time line even if we catch the exception.
- var success = true;
- var context = new OfflineAudioContext(1, testDurationFrames, sampleRate);
- var gain = context.createGain();
- var source = context.createBufferSource();
- var buffer = context.createBuffer(1, 1, context.sampleRate);
+ let success = true;
+ let context = new OfflineAudioContext(1, testDurationFrames, sampleRate);
+ let gain = context.createGain();
+ let source = context.createBufferSource();
+ let buffer = context.createBuffer(1, 1, context.sampleRate);
buffer.getChannelData(0)[0] = 1;
source.buffer = buffer;
source.loop = true;
@@ -183,13 +184,13 @@
});
audit.define("start-end", (task, should) => {
- var context = new OfflineAudioContext(1, testDurationFrames, sampleRate);
- var g = context.createGain();
- var curve = new Float32Array(2);
+ let context = new OfflineAudioContext(1, testDurationFrames, sampleRate);
+ let g = context.createGain();
+ let curve = new Float32Array(2);
// Verify that a setValueCurve can start at the end of an automation.
- var time = 0;
- var timeInterval = testDurationSec / 50;
+ let time = 0;
+ let timeInterval = testDurationSec / 50;
should(() => {
g.gain.setValueAtTime(1, time);
}, "setValueAtTime(1, " + time + ")").notThrow();
@@ -250,9 +251,9 @@
});
audit.define("curve lengths", (task, should) => {
- var context = new OfflineAudioContext(1, testDurationFrames, sampleRate);
- var g = context.createGain();
- var time = 0;
+ let context = new OfflineAudioContext(1, testDurationFrames, sampleRate);
+ let g = context.createGain();
+ let time = 0;
// Check for invalid curve lengths
should(() => {

Powered by Google App Engine
This is Rietveld 408576698