Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(89)

Issue 2892493002: Replace sanitizers:deps with exe_and_shlib_deps (Chromium repo only) (Closed)

Created:
1 year, 10 months ago by Tom Anderson
Modified:
1 year, 10 months ago
Reviewers:
brettw, xhwang
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, zea+watch_chromium.org, vmpstr+watch_chromium.org, oka+watch_chromium.org, ios-reviews+web_chromium.org, johnme+watch_chromium.org, agrieve+watch_chromium.org, tfarina, yzshen+watch_chromium.org, avayvod+watch_chromium.org, pennymac+watch_chromium.org, scheib+watch_chromium.org, ortuno+watch_chromium.org, piman+watch_chromium.org, marq+watch_chromium.org, kinuko+watch, mfoltz+watch_chromium.org, fukino+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, ios-reviews_chromium.org, grt+watch_chromium.org, lcwu+watch_chromium.org, viettrungluu+watch_chromium.org, jam, net-reviews_chromium.org, eme-reviews_chromium.org, darin-cc_chromium.org, sync-reviews_chromium.org, halliwell+watch_chromium.org, huangs+watch_chromium.org, blink-reviews, kalyank, xjz+watch_chromium.org, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, mlamouri+watch-content_chromium.org, chromoting-reviews_chromium.org, imcheng+watch_chromium.org, telemetry-reviews_chromium.org, Peter Beverloo, jasonroberts+watch_google.com, yamaguchi+watch_chromium.org, feature-media-reviews_chromium.org, caitkp+watch_chromium.org, mtomasz+watch_chromium.org, alokp+watch_chromium.org, johnchen+watch_chromium.org, darin (slow to review), jochen+watch_chromium.org, Matt Giuca, Dirk Pranke, wfh+watch_chromium.org, Eugene But (OOO till 7-30), rginda+watch_chromium.org, chromium-apps-reviews_chromium.org, lpromero+watch_chromium.org, ozone-reviews_chromium.org, Aaron Boodman, abarth-chromium, jln+watch_chromium.org, mac-reviews_chromium.org, danakj+watch_chromium.org, isheriff+watch_chromium.org, ios-reviews+showcase_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace sanitizers:deps with exe_and_shlib_deps (Chromium repo only) BUG=723069 R=brettw@chromium.org,xhwang@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2892493002 Cr-Commit-Position: refs/heads/master@{#472971} Committed: https://chromium.googlesource.com/chromium/src/+/84fa8b0864ae839a74233d9cb0bc10fee9a892df

Patch Set 1 #

Patch Set 2 : Fix find/replace error in nacl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -161 lines) Patch
M ash/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M base/android/linker/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M breakpad/BUILD.gn View 13 chunks +13 lines, -13 lines 0 comments Download
M chrome/BUILD.gn View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_watcher/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/mini_installer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/convert_dict/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/service_discovery_sniffer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/BUILD.gn View 7 chunks +7 lines, -7 lines 0 comments Download
M chromecast/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/ios/cronet_consumer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/wifi/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/bluetooth/tools/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M content/shell/android/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M courgette/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M dbus/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M gin/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M gpu/gles2_conform_support/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/tools/compositor_model_bench/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/showcase/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/shell/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/web_view/shell/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mash/runner/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M media/cdm/ppapi/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M net/BUILD.gn View 21 chunks +21 lines, -21 lines 0 comments Download
M net/tools/transport_security_state_generator/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/BUILD.gn View 5 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/linux/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/mac/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M remoting/test/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/tools/javascript_key_tester/pnacl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M rlz/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/linux/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/service_manager/public/cpp/service.gni View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/connect/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/lifecycle/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/service_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M skia/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M storage/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M testing/test.gni View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/android_platform/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/android_protobuf/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/brotli/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/flatbuffers/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/ijar/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/opus/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/protobuf/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/qcms/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/sqlite/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/yasm/BUILD.gn View 7 chunks +7 lines, -7 lines 0 comments Download
M tools/android/forwarder2/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/android/md5sum/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/battor_agent/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/imagediff/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/clear_system_cache/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/xdisplaycheck/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/zip_archiver/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/demo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 46 (39 generated)
Tom Anderson
reviewers ptal xhwang: media/cast/BUILD.gn media/cdm/ppapi/BUILD.gn third_party/widevine/cdm/BUILD.gn brettw: everything else
1 year, 10 months ago (2017-05-17 18:00:37 UTC) #28
Tom Anderson
brettw appears to be busy today, so +sky for all files except: media/cast/BUILD.gn media/cdm/ppapi/BUILD.gn third_party/widevine/cdm/BUILD.gn
1 year, 10 months ago (2017-05-17 18:02:13 UTC) #30
xhwang
media/ rs lgtm
1 year, 10 months ago (2017-05-17 18:46:36 UTC) #31
sky
I didn't get to this today, and I'm not a top-level owner, so I'm kicking ...
1 year, 10 months ago (2017-05-18 02:44:00 UTC) #34
brettw
spot-checked. LGTM
1 year, 10 months ago (2017-05-18 19:18:35 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892493002/80001
1 year, 10 months ago (2017-05-18 23:18:13 UTC) #43
commit-bot: I haz the power
1 year, 10 months ago (2017-05-18 23:39:04 UTC) #46
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/84fa8b0864ae839a74233d9cb0bc...

Powered by Google App Engine
This is Rietveld 408576698