Don't trigger Phishguard pings if we cannot compute URL reputation.

Don't trigger Phishguard pings if we cannot compute URL reputation.

e.g.: private URL/IP addresses, hostname/IP in an IANA-reserved range,
hostname is a not-yet-assigned by ICANN gTLD, dotless domains

Also minor refactor in PasswordProtectionService and
PasswordProtectionService to pass in web_contents in preparation for
showing interstitial.

BUG=722881
Review-Url: https://codereview.chromium.org/2892093003
Cr-Commit-Position: refs/heads/master@{#474005}
Committed: https://chromium.googlesource.com/chromium/src/+/8634cdd25aefa688d90bc1b14106d2a79ece395a

[Jialiu Lin, 2017-05-19 00:35:27]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 00:37:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 03:41:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 03:41:45]

Dry run: This issue passed the CQ dry run.

[Jialiu Lin, 2017-05-19 20:19:20]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 20:20:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2017-05-19 20:31:38]

Description was changed from

==========
Don't trigger Phishguard pings if we cannot compute URL reputation.

e.g.: private URL/IP addresses, hostname/IP in an IANA-reserved range,
hostname is a not-yet-assigned by ICANN gTLD, dotless domains

Also minor refactor in PasswordProtectionService and
PasswordProtectionService to pass in web_contents in preparation of
showing interstitial.

BUG=722881
==========

to

==========
Don't trigger Phishguard pings if we cannot compute URL reputation.

e.g.: private URL/IP addresses, hostname/IP in an IANA-reserved range,
hostname is a not-yet-assigned by ICANN gTLD, dotless domains

Also minor refactor in PasswordProtectionService and
PasswordProtectionService to pass in web_contents in preparation for
showing interstitial.

BUG=722881
==========

[Jialiu Lin, 2017-05-19 20:33:10]

jialiul@chromium.org changed reviewers:
+ nparker@chromium.org

[Jialiu Lin, 2017-05-19 20:33:10]

Hi nparker@,
PTAL Thanks!

[Nathan Parker, 2017-05-20 00:40:06]

LGTM

https://codereview.chromium.org/2892093003/diff/40001/components/safe_browsin...
File components/safe_browsing/password_protection/password_protection_request.h
(right):

https://codereview.chromium.org/2892093003/diff/40001/components/safe_browsin...
components/safe_browsing/password_protection/password_protection_request.h:107:
// WebContents this login form is in.
nit: There may not be a login form if this is a password-entry case.

[Jialiu Lin, 2017-05-22 17:50:43]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 17:51:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2017-05-22 18:35:47]

Thanks nparker@!

https://codereview.chromium.org/2892093003/diff/40001/components/safe_browsin...
File components/safe_browsing/password_protection/password_protection_request.h
(right):

https://codereview.chromium.org/2892093003/diff/40001/components/safe_browsin...
components/safe_browsing/password_protection/password_protection_request.h:107:
// WebContents this login form is in.
On 2017/05/20 00:40:06, Nathan Parker wrote:
> nit: There may not be a login form if this is a password-entry case.

True. Thanks for catching this. Comment updated.

[Jialiu Lin, 2017-05-22 18:35:57]

The CQ bit was unchecked by jialiul@chromium.org

[Jialiu Lin, 2017-05-22 18:36:01]

The CQ bit was checked by jialiul@chromium.org

[Jialiu Lin, 2017-05-22 18:36:02]

The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/2892093003/#ps60001
(title: "update comments")

[commit-bot: I haz the power, 2017-05-22 18:36:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 18:48:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 18:48:39]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jialiu Lin, 2017-05-22 18:56:12]

jialiul@chromium.org changed reviewers:
+ dvadym@chromium.org

[Jialiu Lin, 2017-05-22 18:56:13]

+dvadym@ for password_manager owner review.

[dvadym, 2017-05-23 09:51:09]

On 2017/05/22 18:56:13, Jialiu Lin wrote:
> +dvadym@ for password_manager owner review.

LGTM

[Jialiu Lin, 2017-05-23 16:18:57]

jialiul@chromium.org changed reviewers:
+ isherman@chromium.org

[Jialiu Lin, 2017-05-23 16:18:58]

+isherman@ for minor change to enums.xml

Thanks!

[Ilya Sherman, 2017-05-23 16:22:49]

On 2017/05/23 16:18:58, Jialiu Lin wrote:
> +isherman@ for minor change to enums.xml

You don't need my review for the enums.xml change.

[Jialiu Lin, 2017-05-23 17:43:12]

The CQ bit was checked by jialiul@chromium.org

[commit-bot: I haz the power, 2017-05-23 17:43:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 18:58:31]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495561392241120,
"parent_rev": "01de7ac6d3abe6fdd0f5c78c6fa9c5fa34b5e9ee", "commit_rev":
"8634cdd25aefa688d90bc1b14106d2a79ece395a"}

[commit-bot: I haz the power, 2017-05-23 18:58:40]

Description was changed from

==========
Don't trigger Phishguard pings if we cannot compute URL reputation.

e.g.: private URL/IP addresses, hostname/IP in an IANA-reserved range,
hostname is a not-yet-assigned by ICANN gTLD, dotless domains

Also minor refactor in PasswordProtectionService and
PasswordProtectionService to pass in web_contents in preparation for
showing interstitial.

BUG=722881
==========

to

==========
Don't trigger Phishguard pings if we cannot compute URL reputation.

e.g.: private URL/IP addresses, hostname/IP in an IANA-reserved range,
hostname is a not-yet-assigned by ICANN gTLD, dotless domains

Also minor refactor in PasswordProtectionService and
PasswordProtectionService to pass in web_contents in preparation for
showing interstitial.

BUG=722881

Review-Url: https://codereview.chromium.org/2892093003
Cr-Commit-Position: refs/heads/master@{#474005}
Committed:
https://chromium.googlesource.com/chromium/src/+/8634cdd25aefa688d90bc1b14106...
==========

[commit-bot: I haz the power, 2017-05-23 18:58:42]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8634cdd25aefa688d90bc1b14106...