Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Issue 2892093003: Don't trigger Phishguard pings if we cannot compute URL reputation. (Closed)
Patch Set: update comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
index 8aeeb662f0c7c6595138a4de65507c197fdac83b..381c63521803f23ca72d04564ccf7515d371a43a 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
@@ -85,10 +85,10 @@ class MockPasswordProtectionService
MOCK_METHOD0(IsIncognito, bool());
MOCK_METHOD2(IsPingingEnabled, bool(const base::Feature&, RequestOutcome*));
MOCK_METHOD0(IsHistorySyncEnabled, bool());
- MOCK_METHOD3(MaybeStartPasswordFieldOnFocusRequest,
- void(const GURL&, const GURL&, const GURL&));
- MOCK_METHOD2(MaybeStartProtectedPasswordEntryRequest,
- void(const GURL&, const std::string&));
+ MOCK_METHOD4(MaybeStartPasswordFieldOnFocusRequest,
+ void(WebContents*, const GURL&, const GURL&, const GURL&));
+ MOCK_METHOD3(MaybeStartProtectedPasswordEntryRequest,
+ void(WebContents*, const GURL&, const std::string&));
private:
DISALLOW_COPY_AND_ASSIGN(MockPasswordProtectionService);
@@ -619,7 +619,7 @@ TEST_F(ChromePasswordManagerClientTest,
std::unique_ptr<MockChromePasswordManagerClient> client(
new MockChromePasswordManagerClient(test_web_contents.get()));
EXPECT_CALL(*client->password_protection_service(),
- MaybeStartPasswordFieldOnFocusRequest(_, _, _))
+ MaybeStartPasswordFieldOnFocusRequest(_, _, _, _))
.Times(1);
client->CheckSafeBrowsingReputation(GURL("http://foo.com/submit"),
GURL("http://foo.com/iframe.html"));
@@ -633,7 +633,7 @@ TEST_F(ChromePasswordManagerClientTest,
std::unique_ptr<MockChromePasswordManagerClient> client(
new MockChromePasswordManagerClient(test_web_contents.get()));
EXPECT_CALL(*client->password_protection_service(),
- MaybeStartProtectedPasswordEntryRequest(_, _))
+ MaybeStartProtectedPasswordEntryRequest(_, _, _))
.Times(1);
client->CheckProtectedPasswordEntry(std::string("saved_domain.com"));
}

Powered by Google App Engine
This is Rietveld 408576698