Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 2892093003: Don't trigger Phishguard pings if we cannot compute URL reputation. (Closed)
Patch Set: update comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 7df089164774f9b8c4c5c23cd98e962cbccce25c..b6c0edbde69cc91e9d1d77476679cc4163a0a78d 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -418,10 +418,8 @@ void ChromePasswordManagerClient::CheckSafeBrowsingReputation(
safe_browsing::PasswordProtectionService* pps =
GetPasswordProtectionService();
if (pps) {
- // TODO(jialiul): Pass in web_content() instead of GetMainFrameURL(), such
- // that web_content can be used to display safe browsing interstitial.
- pps->MaybeStartPasswordFieldOnFocusRequest(GetMainFrameURL(), form_action,
- frame_url);
+ pps->MaybeStartPasswordFieldOnFocusRequest(
+ web_contents(), GetMainFrameURL(), form_action, frame_url);
}
}
@@ -430,10 +428,8 @@ void ChromePasswordManagerClient::CheckProtectedPasswordEntry(
safe_browsing::PasswordProtectionService* pps =
GetPasswordProtectionService();
if (pps) {
- // TODO(jialiul): Pass in web_content() instead of GetMainFrameURL(), such
- // that web_content can be used to display safe browsing interstitial.
- pps->MaybeStartProtectedPasswordEntryRequest(GetMainFrameURL(),
- password_saved_domain);
+ pps->MaybeStartProtectedPasswordEntryRequest(
+ web_contents(), GetMainFrameURL(), password_saved_domain);
}
}
#endif
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698