Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2891843004: Replace remaining ASSERT with DCHECK|DCHECK_FOO in core/frame (Closed)

Created:
7 months ago by gyuyoung
Modified:
7 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace remaining ASSERT with DCHECK|DCHECK_FOO in core/frame As a step to reduce uses of wtf/Assertions.h, This CL changes uses of ASSERT with DCHECK() or DCHECK_FOO() in core/frame. BUG=596760 Review-Url: https://codereview.chromium.org/2891843004 Cr-Commit-Position: refs/heads/master@{#473115} Committed: https://chromium.googlesource.com/chromium/src/+/1dc16ecb4daf2aca6cb20a7c7bc29f2f22a8948e

Patch Set 1 #

Patch Set 2 : Replace remaining ASSERT with DCHECK|DCHECK_FOO in core/frame #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/MediaListDirective.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
gyuyoung
PTAL.
7 months ago (2017-05-19 02:01:10 UTC) #2
haraken
LGTM
7 months ago (2017-05-19 02:03:02 UTC) #4
tkent
Please rebase. > BUG=707638 The bug number is incorrect. 707638 is for Source/platform/.
7 months ago (2017-05-19 02:04:07 UTC) #5
gyuyoung
On 2017/05/19 02:04:07, tkent wrote: > Please rebase. > > > BUG=707638 > > The ...
7 months ago (2017-05-19 02:07:34 UTC) #10
tkent
lgtm
7 months ago (2017-05-19 07:01:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891843004/20001
7 months ago (2017-05-19 07:02:41 UTC) #18
commit-bot: I haz the power
7 months ago (2017-05-19 07:07:28 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1dc16ecb4daf2aca6cb20a7c7bc2...

Powered by Google App Engine
This is Rietveld 0eb02b776