third_party/WebKit/Source/core/frame/ImageBitmap.cpp - Issue 2891843004: Replace remaining ASSERT with DCHECK|DCHECK_FOO in core/frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/ImageBitmap.cpp

Issue 2891843004: Replace remaining ASSERT with DCHECK|DCHECK_FOO in core/frame (Closed)

Patch Set: Replace remaining ASSERT with DCHECK|DCHECK_FOO in core/frame Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/ImageBitmap.cpp

diff --git a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp

index 0241feb6268fb4cff305aba4cc213765bae9fc5d..8d64e040611ec9345a2328ce2f1b92904ca401ea 100644

--- a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp

+++ b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp

@@ -1089,7 +1089,8 @@ bool ImageBitmap::IsAccelerated() const {

IntSize ImageBitmap::Size() const {

if (!image_)

return IntSize();

- ASSERT(image_->width() > 0 && image_->height() > 0);

+ DCHECK_GT(image_->width(), 0);

+ DCHECK_GT(image_->height(), 0);

return IntSize(image_->width(), image_->height());

}