Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 2891843004: Replace remaining ASSERT with DCHECK|DCHECK_FOO in core/frame (Closed)
Patch Set: Replace remaining ASSERT with DCHECK|DCHECK_FOO in core/frame Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
index 404cbce7edeae5b552ab277f169a24e59853fa1c..dda32e052122cb60e977bd3e2bb2bfc961f29205 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
@@ -289,8 +289,8 @@ void LocalFrame::Init() {
}
void LocalFrame::SetView(FrameView* view) {
- ASSERT(!view_ || view_ != view);
- ASSERT(!GetDocument() || !GetDocument()->IsActive());
+ DCHECK(!view_ || view_ != view);
+ DCHECK(!GetDocument() || !GetDocument()->IsActive());
GetEventHandler().Clear();
@@ -649,8 +649,8 @@ FloatSize LocalFrame::ResizePageRectsKeepingRatio(
result_size.SetWidth(floorf(expected_size.Width()));
result_size.SetHeight(floorf(result_size.Width() * ratio));
} else {
- ASSERT(fabs(original_size.Height()) >
- std::numeric_limits<float>::epsilon());
+ DCHECK_GT(fabs(original_size.Height()),
+ std::numeric_limits<float>::epsilon());
float ratio = original_size.Width() / original_size.Height();
result_size.SetHeight(floorf(expected_size.Height()));
result_size.SetWidth(floorf(result_size.Height() * ratio));
« no previous file with comments | « third_party/WebKit/Source/core/frame/ImageBitmap.cpp ('k') | third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698