Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2891563002: Add workaround for Mac stencil buffer leak (Closed)

Created:
3 years, 7 months ago by ericrk
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Add workaround for Mac stencil buffer leak This change adds a new workaround, "avoid_stencil_buffers", which is enabled on certain Macs with leaky drivers. This workaround currently only forwards to Skia, enabling a mode where stencil buffers are avoided. BUG=713854 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2866353002 Cr-Original-Commit-Position: refs/heads/master@{#470712} Review-Url: https://codereview.chromium.org/2891563002 . Cr-Commit-Position: refs/branch-heads/3071@{#589} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/84f3edbaa712fc88efa0ae9a26a3953abb99b752

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -11 lines) Patch
M cc/output/in_process_context_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/test_in_process_context_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/common/capabilities.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list.json View 2 chunks +15 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/ipc/common/gpu_command_buffer_traits_multi.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/skia_bindings/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/skia_bindings/grcontext_for_gles2_interface.h View 2 chunks +4 lines, -1 line 0 comments Download
M gpu/skia_bindings/grcontext_for_gles2_interface.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M services/ui/public/cpp/gpu/context_provider_command_buffer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/compositor/test/in_process_context_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
ericrk
3 years, 7 months ago (2017-05-16 21:51:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
84f3edbaa712fc88efa0ae9a26a3953abb99b752.

Powered by Google App Engine
This is Rietveld 408576698