Add workaround for Mac stencil buffer leak

Add workaround for Mac stencil buffer leak

This change adds a new workaround, "avoid_stencil_buffers", which is
enabled on certain Macs with leaky drivers. This workaround currently
only forwards to Skia, enabling a mode where stencil buffers are
avoided.

BUG=713854
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2866353002
Cr-Commit-Position: refs/heads/master@{#470712}
Committed: https://chromium.googlesource.com/chromium/src/+/4f3b335015f66c266bc1ed11f7b22761907df6f4

[ericrk, 2017-05-09 21:48:18]

Description was changed from

==========
Add workaround for Mac stencil buffer leak

This change adds a new workaround, "avoid_stencil_buffers", which is
enabled on certain Macs with leaky drivers. This workaround currently
only forwards to Skia, enabling a mode where stencil buffers are
avoided.

BUG=713854
==========

to

==========
Add workaround for Mac stencil buffer leak

This change adds a new workaround, "avoid_stencil_buffers", which is
enabled on certain Macs with leaky drivers. This workaround currently
only forwards to Skia, enabling a mode where stencil buffers are
avoided.

BUG=713854
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ericrk, 2017-05-09 21:48:19]

Description was changed from

==========
Add workaround for Mac stencil buffer leak

This change adds a new workaround, "avoid_stencil_buffers", which is
enabled on certain Macs with leaky drivers. This workaround currently
only forwards to Skia, enabling a mode where stencil buffers are
avoided.

BUG=713854
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add workaround for Mac stencil buffer leak

This change adds a new workaround, "avoid_stencil_buffers", which is
enabled on certain Macs with leaky drivers. This workaround currently
only forwards to Skia, enabling a mode where stencil buffers are
avoided.

BUG=713854
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ericrk, 2017-05-09 21:57:00]

ericrk@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2017-05-09 22:17:45]

lgtm

[ericrk, 2017-05-10 16:37:24]

ericrk@chromium.org changed reviewers:
+ tsepez@chromium.org

[ericrk, 2017-05-10 16:37:24]

+tsepez for gpu\ipc\common\gpu_command_buffer_traits_multi.h

Thanks!

[ericrk, 2017-05-10 16:37:29]

The CQ bit was checked by ericrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 16:38:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2017-05-10 16:39:01]

RS LGTM on adding a bool.

[commit-bot: I haz the power, 2017-05-10 16:44:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 16:44:28]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[ericrk, 2017-05-10 17:46:00]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2017-05-10 17:46:01]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2866353002/#ps40001
(title: "Fix analyze issue")

[commit-bot: I haz the power, 2017-05-10 17:47:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 21:17:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494438360994270,
"parent_rev": "4374b957b1158e5a05c945adec770bdcc351c808", "commit_rev":
"4f3b335015f66c266bc1ed11f7b22761907df6f4"}

[commit-bot: I haz the power, 2017-05-10 21:17:57]

Description was changed from

==========
Add workaround for Mac stencil buffer leak

This change adds a new workaround, "avoid_stencil_buffers", which is
enabled on certain Macs with leaky drivers. This workaround currently
only forwards to Skia, enabling a mode where stencil buffers are
avoided.

BUG=713854
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add workaround for Mac stencil buffer leak

This change adds a new workaround, "avoid_stencil_buffers", which is
enabled on certain Macs with leaky drivers. This workaround currently
only forwards to Skia, enabling a mode where stencil buffers are
avoided.

BUG=713854
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2866353002
Cr-Commit-Position: refs/heads/master@{#470712}
Committed:
https://chromium.googlesource.com/chromium/src/+/4f3b335015f66c266bc1ed11f7b2...
==========

[commit-bot: I haz the power, 2017-05-10 21:17:58]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4f3b335015f66c266bc1ed11f7b2...