bindings: Use an alias for @@iterator in certain declarations.

bindings: Use an alias for @@iterator in certain declarations.

So far, the generated bindings had completely separate methods for
entries(), values() and the @@iterator symbol, all of which were added
automatically if an IDL has an iterable<>, maplike<> or setlike<>
declaration.

However, the WebIDL spec states that:
* Pair iterators (iterable<K,V>) and maplike declarations (maplike<K,V>)
  should add the same Function object for both @@iterator and entries(), and
  its name attribute should be "entries".
* Setlike declarations (setlike<V>) should add the same Function object for
  both @@iterator and values(), and its name attribute should be "values".

Fix it by adding SymbolKeyedMethodConfiguration::symbol_alias, an optional
string that can be used to add the same function template as both a symbol
as well as this string (which will also be used as the Function object's
name attribute).

While here, bring back a simpler version of the ValueIterable class removed
in commit c85bc0151 ("bindings: Make some value iterator properties aliases
to Array.prototype functions") and call it SetlikeIterable instead. As the
name suggests, we need it for interfaces with setlike declarations instead
of "iterable<V>" declarations: the latter uses the definitions from
%ArrayPrototype%, while the former do not.

SetlikeIterable is currently used by FontFaceSet, which is our only IDL with
a setlike declaration and whose C++ implementation was previously inheriting
from PairIterable, leading @@iterator to call entriesForBinding() instead of
valuesForBinding() instead.

BUG=723648
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2891063003
Cr-Commit-Position: refs/heads/master@{#473558}
Committed: https://chromium.googlesource.com/chromium/src/+/1bd6e150922b18cd1fa5e0f14482ecf691ba3377

[Raphael Kubo da Costa (rakuco), 2017-05-19 14:54:22]

Description was changed from

==========
bindings: Use an alias for @@iterator in certain declarations.

So far, the generated bindings had completely separate methods for
entries(), values() and the @@iterator symbol, all of which were added
automatically if an IDL has an iterable<>, maplike<> or setlike<>
declaration.

However, the WebIDL spec states that:
* Pair iterators (iterable<K,V>) and maplike declarations (maplike<K,V>)
  should add the same Function object for both @@iterator and entries(), and
  its name attribute should be "entries".
* Setlike declarations (setlike<V>) should add the same Function object for
  both @@iterator and values(), and its name attribute should be "values".

Fix by adding SymbolKeyedMethodConfiguration::symbol_alias, an optional
string that can be used to add the same function template as both a symbol
as well as this string (which will also be used as the Function object's
name attribute).

BUG=723648
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org
==========

to

==========
bindings: Use an alias for @@iterator in certain declarations.

So far, the generated bindings had completely separate methods for
entries(), values() and the @@iterator symbol, all of which were added
automatically if an IDL has an iterable<>, maplike<> or setlike<>
declaration.

However, the WebIDL spec states that:
* Pair iterators (iterable<K,V>) and maplike declarations (maplike<K,V>)
  should add the same Function object for both @@iterator and entries(), and
  its name attribute should be "entries".
* Setlike declarations (setlike<V>) should add the same Function object for
  both @@iterator and values(), and its name attribute should be "values".

Fix it by adding SymbolKeyedMethodConfiguration::symbol_alias, an optional
string that can be used to add the same function template as both a symbol
as well as this string (which will also be used as the Function object's
name attribute).

While here, bring back a simpler version of the ValueIterable class removed
in commit c85bc0151 ("bindings: Make some value iterator properties aliases
to Array.prototype functions") and call it SetlikeIterable instead. As the
name suggests, we need it for interfaces with setlike declarations instead
of "iterable<V>" declarations: the latter uses the definitions from
%ArrayPrototype%, while the former do not.

SetlikeIterable is currently used by FontFaceSet, which is our only IDL with
a setlike declaration and whose C++ implementation was previously inheriting
from PairIterable, leading @@iterator to call entriesForBinding() instead of
valuesForBinding() instead.

BUG=723648
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org
==========

[Raphael Kubo da Costa (rakuco), 2017-05-19 14:54:22]

raphael.kubo.da.costa@intel.com changed reviewers:
+ meade@chromium.org

[Raphael Kubo da Costa (rakuco), 2017-05-19 14:54:50]

PTAL

[Raphael Kubo da Costa (rakuco), 2017-05-19 14:54:59]

The CQ bit was checked by raphael.kubo.da.costa@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 14:55:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 16:39:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 16:39:56]

Dry run: This issue passed the CQ dry run.

[haraken, 2017-05-20 00:03:36]

LGTM

[bashi, 2017-05-21 23:27:48]

lgtm

https://codereview.chromium.org/2891063003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/v8_interface.py (right):

https://codereview.chromium.org/2891063003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/v8_interface.py:751: return methods,
iterator_method, iterator_method_alias
nit: I'd prefer to use a dict here.

[Raphael Kubo da Costa (rakuco), 2017-05-22 09:29:52]

https://codereview.chromium.org/2891063003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/v8_interface.py (right):

https://codereview.chromium.org/2891063003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/v8_interface.py:751: return methods,
iterator_method, iterator_method_alias
On 2017/05/21 23:27:48, bashi wrote:
> nit: I'd prefer to use a dict here.

Makes total sense :) Done in patch v3, which I'll try to land.

[Raphael Kubo da Costa (rakuco), 2017-05-22 09:29:58]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[Raphael Kubo da Costa (rakuco), 2017-05-22 09:29:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, bashi@chromium.org
Link to the patchset: https://codereview.chromium.org/2891063003/#ps40001
(title: "Make methods_context() return a dict")

[commit-bot: I haz the power, 2017-05-22 09:30:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 09:32:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 09:32:31]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Raphael Kubo da Costa (rakuco), 2017-05-22 10:11:40]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[Raphael Kubo da Costa (rakuco), 2017-05-22 10:11:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, bashi@chromium.org
Link to the patchset: https://codereview.chromium.org/2891063003/#ps60001
(title: "Rebase patch")

[commit-bot: I haz the power, 2017-05-22 10:11:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 12:48:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495447900009260,
"parent_rev": "fb7b20e38b88a3418e6c6325e1e3d99b8a3e857d", "commit_rev":
"1bd6e150922b18cd1fa5e0f14482ecf691ba3377"}

[commit-bot: I haz the power, 2017-05-22 12:48:53]

Description was changed from

==========
bindings: Use an alias for @@iterator in certain declarations.

So far, the generated bindings had completely separate methods for
entries(), values() and the @@iterator symbol, all of which were added
automatically if an IDL has an iterable<>, maplike<> or setlike<>
declaration.

However, the WebIDL spec states that:
* Pair iterators (iterable<K,V>) and maplike declarations (maplike<K,V>)
  should add the same Function object for both @@iterator and entries(), and
  its name attribute should be "entries".
* Setlike declarations (setlike<V>) should add the same Function object for
  both @@iterator and values(), and its name attribute should be "values".

Fix it by adding SymbolKeyedMethodConfiguration::symbol_alias, an optional
string that can be used to add the same function template as both a symbol
as well as this string (which will also be used as the Function object's
name attribute).

While here, bring back a simpler version of the ValueIterable class removed
in commit c85bc0151 ("bindings: Make some value iterator properties aliases
to Array.prototype functions") and call it SetlikeIterable instead. As the
name suggests, we need it for interfaces with setlike declarations instead
of "iterable<V>" declarations: the latter uses the definitions from
%ArrayPrototype%, while the former do not.

SetlikeIterable is currently used by FontFaceSet, which is our only IDL with
a setlike declaration and whose C++ implementation was previously inheriting
from PairIterable, leading @@iterator to call entriesForBinding() instead of
valuesForBinding() instead.

BUG=723648
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org
==========

to

==========
bindings: Use an alias for @@iterator in certain declarations.

So far, the generated bindings had completely separate methods for
entries(), values() and the @@iterator symbol, all of which were added
automatically if an IDL has an iterable<>, maplike<> or setlike<>
declaration.

However, the WebIDL spec states that:
* Pair iterators (iterable<K,V>) and maplike declarations (maplike<K,V>)
  should add the same Function object for both @@iterator and entries(), and
  its name attribute should be "entries".
* Setlike declarations (setlike<V>) should add the same Function object for
  both @@iterator and values(), and its name attribute should be "values".

Fix it by adding SymbolKeyedMethodConfiguration::symbol_alias, an optional
string that can be used to add the same function template as both a symbol
as well as this string (which will also be used as the Function object's
name attribute).

While here, bring back a simpler version of the ValueIterable class removed
in commit c85bc0151 ("bindings: Make some value iterator properties aliases
to Array.prototype functions") and call it SetlikeIterable instead. As the
name suggests, we need it for interfaces with setlike declarations instead
of "iterable<V>" declarations: the latter uses the definitions from
%ArrayPrototype%, while the former do not.

SetlikeIterable is currently used by FontFaceSet, which is our only IDL with
a setlike declaration and whose C++ implementation was previously inheriting
from PairIterable, leading @@iterator to call entriesForBinding() instead of
valuesForBinding() instead.

BUG=723648
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2891063003
Cr-Commit-Position: refs/heads/master@{#473558}
Committed:
https://chromium.googlesource.com/chromium/src/+/1bd6e150922b18cd1fa5e0f14482...
==========

[commit-bot: I haz the power, 2017-05-22 12:48:54]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1bd6e150922b18cd1fa5e0f14482...

[Yuki, 2017-05-22 13:05:17]

LGTM.