third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl - Issue 2891063003: bindings: Use an alias for @@iterator in certain declarations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

Issue 2891063003: bindings: Use an alias for @@iterator in certain declarations. (Closed)

Patch Set: Rebase patch Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_interface.py ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

index ac9fa3021d763798c61b177fd6068fbb2fba013d..732de323a56750f53fcd34a72786fec34c02d380 100644

--- a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

@@ -531,8 +531,10 @@ static void install{{v8_class}}Template(v8::Isolate* isolate, const DOMWrapperWo

{% if iterator_method %}

{% filter exposed(iterator_method.exposed_test) %}

{% filter runtime_enabled(iterator_method.runtime_enabled_feature_name) %}

+ {% set symbol_alias = '"%s"' % iterator_method_alias

+ if iterator_method_alias else 'nullptr' %}

// Iterator (@@iterator)

- static const V8DOMConfiguration::SymbolKeyedMethodConfiguration symbolKeyedIteratorConfiguration = { v8::Symbol::GetIterator, {{v8_class_or_partial}}::iteratorMethodCallback, 0, v8::DontEnum, V8DOMConfiguration::kOnPrototype, V8DOMConfiguration::kCheckHolder, V8DOMConfiguration::kDoNotCheckAccess };

+ static const V8DOMConfiguration::SymbolKeyedMethodConfiguration symbolKeyedIteratorConfiguration = { v8::Symbol::GetIterator, {{symbol_alias}}, {{v8_class_or_partial}}::iteratorMethodCallback, 0, v8::DontEnum, V8DOMConfiguration::kOnPrototype, V8DOMConfiguration::kCheckHolder, V8DOMConfiguration::kDoNotCheckAccess };

V8DOMConfiguration::InstallMethod(isolate, world, prototypeTemplate, signature, symbolKeyedIteratorConfiguration);

{% endfilter %}