Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

Issue 2891063003: bindings: Use an alias for @@iterator in certain declarations. (Closed)
Patch Set: Rebase patch Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% filter format_blink_cpp_source_code %} 1 {% filter format_blink_cpp_source_code %}
2 2
3 {% include 'copyright_block.txt' %} 3 {% include 'copyright_block.txt' %}
4 #include "{{v8_class_or_partial}}.h" 4 #include "{{v8_class_or_partial}}.h"
5 5
6 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %} 6 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %}
7 #include "{{filename}}" 7 #include "{{filename}}"
8 {% endfor %} 8 {% endfor %}
9 9
10 namespace blink { 10 namespace blink {
(...skipping 513 matching lines...) Expand 10 before | Expand all | Expand 10 after
524 prototypeTemplate->SetIntrinsicDataProperty(V8AtomicString(isolate, "entries") , v8::kArrayProto_entries); 524 prototypeTemplate->SetIntrinsicDataProperty(V8AtomicString(isolate, "entries") , v8::kArrayProto_entries);
525 prototypeTemplate->SetIntrinsicDataProperty(V8AtomicString(isolate, "forEach") , v8::kArrayProto_forEach); 525 prototypeTemplate->SetIntrinsicDataProperty(V8AtomicString(isolate, "forEach") , v8::kArrayProto_forEach);
526 prototypeTemplate->SetIntrinsicDataProperty(V8AtomicString(isolate, "keys"), v 8::kArrayProto_keys); 526 prototypeTemplate->SetIntrinsicDataProperty(V8AtomicString(isolate, "keys"), v 8::kArrayProto_keys);
527 prototypeTemplate->SetIntrinsicDataProperty(V8AtomicString(isolate, "values"), v8::kArrayProto_values); 527 prototypeTemplate->SetIntrinsicDataProperty(V8AtomicString(isolate, "values"), v8::kArrayProto_values);
528 {% endif %} 528 {% endif %}
529 {% endif %} 529 {% endif %}
530 530
531 {% if iterator_method %} 531 {% if iterator_method %}
532 {% filter exposed(iterator_method.exposed_test) %} 532 {% filter exposed(iterator_method.exposed_test) %}
533 {% filter runtime_enabled(iterator_method.runtime_enabled_feature_name) %} 533 {% filter runtime_enabled(iterator_method.runtime_enabled_feature_name) %}
534 {% set symbol_alias = '"%s"' % iterator_method_alias
535 if iterator_method_alias else 'nullptr' %}
534 // Iterator (@@iterator) 536 // Iterator (@@iterator)
535 static const V8DOMConfiguration::SymbolKeyedMethodConfiguration symbolKeyedIte ratorConfiguration = { v8::Symbol::GetIterator, {{v8_class_or_partial}}::iterato rMethodCallback, 0, v8::DontEnum, V8DOMConfiguration::kOnPrototype, V8DOMConfigu ration::kCheckHolder, V8DOMConfiguration::kDoNotCheckAccess }; 537 static const V8DOMConfiguration::SymbolKeyedMethodConfiguration symbolKeyedIte ratorConfiguration = { v8::Symbol::GetIterator, {{symbol_alias}}, {{v8_class_or_ partial}}::iteratorMethodCallback, 0, v8::DontEnum, V8DOMConfiguration::kOnProto type, V8DOMConfiguration::kCheckHolder, V8DOMConfiguration::kDoNotCheckAccess };
536 V8DOMConfiguration::InstallMethod(isolate, world, prototypeTemplate, signature , symbolKeyedIteratorConfiguration); 538 V8DOMConfiguration::InstallMethod(isolate, world, prototypeTemplate, signature , symbolKeyedIteratorConfiguration);
537 {% endfilter %} 539 {% endfilter %}
538 {% endfilter %} 540 {% endfilter %}
539 {% endif %} 541 {% endif %}
540 542
541 {% if interface_name == 'Iterator' %} 543 {% if interface_name == 'Iterator' %}
542 // The WebIDL spec says when an interface has pair iterators the iterators it 544 // The WebIDL spec says when an interface has pair iterators the iterators it
543 // returns must be instances of the "default iterator object" whose 545 // returns must be instances of the "default iterator object" whose
544 // [[Prototype]] points to an "iterator prototype object" whose 546 // [[Prototype]] points to an "iterator prototype object" whose
545 // [[Prototype]], on its turn, points to %IteratorPrototype%. next() must be 547 // [[Prototype]], on its turn, points to %IteratorPrototype%. next() must be
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
809 {% endif %} 811 {% endif %}
810 } 812 }
811 {% endif %} 813 {% endif %}
812 814
813 {% endblock %} 815 {% endblock %}
814 {##############################################################################} 816 {##############################################################################}
815 {% block partial_interface %}{% endblock %} 817 {% block partial_interface %}{% endblock %}
816 } // namespace blink 818 } // namespace blink
817 819
818 {% endfilter %}{# format_blink_cpp_source_code #} 820 {% endfilter %}{# format_blink_cpp_source_code #}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698