Issue 289083003: [dartium] Dart half of ScriptValue refactoring.

Issue 289083003: [dartium] Dart half of ScriptValue refactoring. (Closed)

Created:
6 years, 7 months ago by rmacnak

Modified:
6 years, 7 months ago

Reviewers:
vsm, siva

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/blink/branches/dart/1916

Visibility:
Public.

More Reviews

Description

[dartium] Dart half of ScriptValue refactoring. R=asiva@google.com Committed: https://src.chromium.org/viewvc/multivm/branches/1650/blink?view=rev&revision=174596

Patch Set 3 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+185 lines, -58 lines)			Patch
M	Source/bindings/common/AbstractScriptValue.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/bindings/common/ScriptValue.h	View	1	3 chunks	+15 lines, -2 lines	0 comments	Download
M	Source/bindings/dart/DartHandleProxy.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/bindings/dart/DartHandleProxy.cpp	View		6 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/bindings/dart/DartJsInterop.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A +	Source/bindings/dart/DartPersistentValue.h	View		2 chunks	+9 lines, -10 lines	0 comments	Download
A +	Source/bindings/dart/DartPersistentValue.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/bindings/dart/DartScriptValue.h	View	1 2	2 chunks	+95 lines, -11 lines	0 comments	Download
M	Source/bindings/dart/DartScriptValue.cpp	View		2 chunks	+37 lines, -9 lines	0 comments	Download
M	Source/bindings/dart/DartUtilities.h	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/bindings/dart/DartUtilities.cpp	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	Source/bindings/dart/gyp/overrides.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/bindings/dart/scripts/dart_types.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/V8ScriptValue.h	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM with some comments https://codereview.chromium.org/289083003/diff/90001/Source/bindings/dart/DartPersistentValue.cpp File Source/bindings/dart/DartPersistentValue.cpp (right): https://codereview.chromium.org/289083003/diff/90001/Source/bindings/dart/DartPersistentValue.cpp#newcode49 Source/bindings/dart/DartPersistentValue.cpp:49: Dart_DeletePersistentHandle(m_value); I don't think DeletePersistentHandle ...

6 years, 7 months ago (2014-05-21 21:56:17 UTC) #2

rmacnak

https://codereview.chromium.org/289083003/diff/90001/Source/bindings/dart/DartPersistentValue.cpp File Source/bindings/dart/DartPersistentValue.cpp (right): https://codereview.chromium.org/289083003/diff/90001/Source/bindings/dart/DartPersistentValue.cpp#newcode49 Source/bindings/dart/DartPersistentValue.cpp:49: Dart_DeletePersistentHandle(m_value); On 2014/05/21 21:56:17, siva wrote: > I don't ...

6 years, 7 months ago (2014-05-22 20:27:19 UTC) #3

rmacnak

6 years, 7 months ago (2014-05-22 20:50:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r174596 (presubmit successful).

Expand Messages | Collapse Messages