Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: Source/bindings/dart/DartJsInterop.cpp

Issue 289083003: [dartium] Dart half of ScriptValue refactoring. (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/1916
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/dart/DartHandleProxy.cpp ('k') | Source/bindings/dart/DartPersistentValue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/dart/DartJsInterop.cpp
diff --git a/Source/bindings/dart/DartJsInterop.cpp b/Source/bindings/dart/DartJsInterop.cpp
index ba91725a100f51edf6d2faf6e136f438f1d9ab7d..65db3791a9c188e1fd29e92b2ded2a8f04ad932d 100644
--- a/Source/bindings/dart/DartJsInterop.cpp
+++ b/Source/bindings/dart/DartJsInterop.cpp
@@ -34,7 +34,7 @@
#include "DartJsInteropData.h"
#include "bindings/dart/DartDOMWrapper.h"
#include "bindings/dart/DartHandleProxy.h"
-#include "bindings/dart/DartScriptValue.h"
+#include "bindings/dart/DartPersistentValue.h"
#include "bindings/dart/DartUtilities.h"
#include "bindings/dart/V8Converter.h"
#include "bindings/v8/V8Binding.h"
@@ -266,7 +266,7 @@ Dart_Handle JsInterop::toDart(v8::Local<v8::Value> v8Handle)
// If this use case is important we can support it at the cost of hanging
// an extra expando off the JS function wrapping the Dart function.
if (DartHandleProxy::isDartProxy(v8Handle)) {
- DartScriptValue* scriptValue = DartHandleProxy::readPointerFromProxy(v8Handle);
+ DartPersistentValue* scriptValue = DartHandleProxy::readPointerFromProxy(v8Handle);
ASSERT(scriptValue->isIsolateAlive());
return scriptValue->value();
}
« no previous file with comments | « Source/bindings/dart/DartHandleProxy.cpp ('k') | Source/bindings/dart/DartPersistentValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698