[dartium] Dart half of ScriptValue refactoring.

Source/bindings/dart/DartPersistentValue.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 #include "config.h"
-#include "bindings/dart/DartScriptValue.h"
+#include "bindings/dart/DartPersistentValue.h"
 
 #include "bindings/dart/DartDOMData.h"
 #include "bindings/dart/DartUtilities.h"
 
 namespace WebCore {
 
-DartScriptValue::DartScriptValue(Dart_Handle value)
+DartPersistentValue::DartPersistentValue(Dart_Handle value)
 {
     m_value = Dart_NewPersistentHandle(value);
 }
 
-DartScriptValue::~DartScriptValue()
+DartPersistentValue::~DartPersistentValue()
 {
     if (!isIsolateAlive())
         return;
 
     DartIsolateScope scope(isolate());
     Dart_DeletePersistentHandle(m_value);

[siva, 2014/05/21 21:56:17]

I don't think DeletePersistentHandle requires a new Dart Scope to be setup.

[rmacnak, 2014/05/22 20:27:19]

This sets the current isolate; it doesn't create a new handle scope. Maybe it
can be removed when handles store their isolate.

 }
 
 }